Skip to content

Commit

Permalink
Fixing VSCE build by removing uneeded steps
Browse files Browse the repository at this point in the history
  • Loading branch information
joehan committed Jan 9, 2025
1 parent a1d61ec commit 255eb0e
Showing 1 changed file with 12 additions and 11 deletions.
23 changes: 12 additions & 11 deletions firebase-vscode/webpack.common.js
Original file line number Diff line number Diff line change
Expand Up @@ -191,19 +191,20 @@ const extensionConfig = {
from: "../schema",
to: "./schema",
},
// TODO(hlshen): Sanity check if these should be fixed or removed. AFIACT, they exist for functions and hosting deploys, which are not relevant anymore.
// Copy uncompiled JS files called at runtime by
// firebase-tools/src/parseTriggers.ts
{
from: "*.js",
to: "./",
context: "../src/deploy/functions/runtimes/node",
},
// Copy cross-env-shell.js used to run predeploy scripts
// to ensure they work in Windows
{
from: "../node_modules/cross-env/dist",
to: "./cross-env/dist",
},
// {
// from: "*.js",
// to: "./",
// context: "../src/deploy/functions/runtimes/node",
// },
// // Copy cross-env-shell.js used to run predeploy scripts
// // to ensure they work in Windows
// {
// from: "../node_modules/cross-env/dist",
// to: "./cross-env/dist",
// },
],
}),
],
Expand Down

0 comments on commit 255eb0e

Please sign in to comment.