Adjust control flow with some placeholder TODOs.

Author: rosalyntan

src/dataconnect/build.ts

@@ -5,36 +5,48 @@ import * as experiments from "../experiments";
 import { prettify } from "./graphqlError";
 import { DeploymentMetadata } from "./types";
 
-export async function build(options: Options, configDir: string, dryRun?: boolean): Promise<DeploymentMetadata> {
-  var args: {configDir: string, projectId?: string} = { configDir }
+export async function build(
+  options: Options,
+  configDir: string,
+  dryRun?: boolean,
+): Promise<DeploymentMetadata> {
+  const args: { configDir: string; projectId?: string } = { configDir };
   if (experiments.isEnabled("fdcconnectorevolution") && options.projectId) {
-    process.env["DATA_CONNECT_PREVIEW"] = "conn_evolution"
-    args.projectId = options.projectId
+    process.env["DATA_CONNECT_PREVIEW"] = "conn_evolution";
+    args.projectId = options.projectId;
   }
   const buildResult = await DataConnectEmulator.build(args);
   if (buildResult?.errors?.length) {
-    if (buildResult.errors.filter(e => !e.warningLevel)) {
+    if (buildResult.errors.filter((w) => !w.warningLevel).length) {
       // Throw immediately if there are any build errors in the GraphQL schema or connectors.
       throw new FirebaseError(
         `There are errors in your schema and connector files:\n${buildResult.errors.map(prettify).join("\n")}`,
       );
-    } else {
-      for (let e of buildResult.errors) {
-        if (options.interactive) {
-          if (dryRun || options.force) {
-            // TODO: Log messages in output.
-          } else {
-            // TODO: Prompt messages and error if rejected.
-            // Interactive default to accept, required default to reject.
-          }
-        } else if (options.nonInteractive) {
-        }
+    }
+    const interactiveAcks = buildResult.errors.filter(
+      (w) => w.warningLevel && w.warningLevel === "INTERACTIVE_ACK",
+    );
+    const requiredAcks = buildResult.errors.filter(
+      (w) => w.warningLevel && w.warningLevel === "REQUIRE_ACK",
+    );
+    if (requiredAcks.length) {
+      if (options.nonInteractive && !options.force) {
+        throw new FirebaseError(
+          `There are changes in your schema or connectors that may break your existing applications. These changes require explicit acknowledgement to deploy:\n${requiredAcks.map(prettify).join("\n")}`,
+        );
+      } else if (options.interactive && !options.force && !dryRun) {
+        // TODO: Prompt message and error if rejected. Default to reject.
+      } else {
+        // TODO: Log messages in output.
+      }
+    }
+    if (interactiveAcks.length) {
+      if (options.interactive && !options.force && !dryRun) {
+        // TODO: Prompt message and error if rejected. Default to accept.
+      } else {
+        // TODO: Log messages in output.
       }
     }
   }
   return buildResult?.metadata ?? {};
 }
-
-async function prompt(options: Options): Promise<boolean> {
-  return true;
-}

src/emulator/dataconnectEmulator.ts

@@ -243,7 +243,7 @@ export class DataConnectEmulator implements EmulatorInstance {
     const commandInfo = await downloadIfNecessary(Emulators.DATACONNECT);
     const cmd = ["--logtostderr", "-v=2", "build", `--config_dir=${args.configDir}`];
     if (args.projectId) {
-      cmd.push(`--project_id=${args.projectId}`)
+      cmd.push(`--project_id=${args.projectId}`);
     }
 
     const res = childProcess.spawnSync(commandInfo.binary, cmd, { encoding: "utf-8" });