Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ajv 6.12.6 -> 8.17.1 #8091

Merged
merged 2 commits into from
Jan 3, 2025
Merged

ajv 6.12.6 -> 8.17.1 #8091

merged 2 commits into from
Jan 3, 2025

Conversation

sarahec
Copy link
Contributor

@sarahec sarahec commented Jan 2, 2025

Description

  1. Bumped ajv dependency from ^6.12.6 to ^8.17.1 (latest)
  2. Added ajv-formats module in firebaseConfigValidate.ts to include definition for uri
  3. Replaced error.dataPath with instancePath (deprecated in ajv 7, removed in ajv 8; see ajv migration notes)

Fixes #8088

Scenarios Tested

Ran npm run test. No failures. 2906 passing, 4 pending.

Sample Commands

n/a

Copy link

google-cla bot commented Jan 2, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sarahec sarahec changed the title ajv 6.12.6 -> 8.1.1 ajv 6.12.6 -> 8.17.1 Jan 2, 2025
@sarahec sarahec force-pushed the push-rnynwlorlwpr branch from 785df82 to 6fd42d0 Compare January 2, 2025 19:48
@sarahec sarahec force-pushed the push-rnynwlorlwpr branch from 6fd42d0 to 161aa6f Compare January 2, 2025 19:55
@joehan joehan merged commit b684155 into firebase:master Jan 3, 2025
9 of 13 checks passed
@sarahec sarahec deleted the push-rnynwlorlwpr branch January 6, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error under nix due to four year old ajv
2 participants