[Refactor] Extract a shared init Feature interface for all product #8535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
approved these changes
May 12, 2025
src/init/features/hosting/github.ts
Outdated
| @@ -132,7 +132,7 @@ export async function initGitHub(setup: Setup): Promise<void> { | |||
|
|
|||
| // If the developer is using predeploy scripts in firebase.json, | |||
| // remind them before they set up a script in their workflow file. | |||
| if (setup.config.hosting.predeploy) { | |||
| if ((setup.config.hosting as any).predeploy) { | |||
There was a problem hiding this comment.
Does the type system let us switch this to something like:
if (!Array.isArray(setup.config.hosting) && setup.config.hosting.predeploy) {
}
I think the existing code here is a bit broken and will never trigger if you have a HostingMulitple in your config. If you're feeling inspired, we could fix that, but since its just an informational mssage I'm ok leaving it as is
There was a problem hiding this comment.
Just tested, it does accept that.
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8535 +/- ##
==========================================
- Coverage 51.04% 51.01% -0.03%
==========================================
Files 426 426
Lines 30562 30598 +36
Branches 6271 6276 +5
==========================================
+ Hits 15599 15609 +10
- Misses 13574 13601 +27
+ Partials 1389 1388 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous:
(setup: any, config: any, options?: any) => Promise<unknown>Now:
(setup: Setup, config: Config, options?: any) => Promise<unknown>Mostly refactor to make TS compiler happy:
database: rewrite to useSetuptype.genkit: seems to be doing something bad or wrong with theSetupargument. Duct-tap it in the caller site for now.Hoping to incrementally make it easier to define a shared
askQuestion, thenactuatesplit for products. ThedoSetupfunc can remain as the old way during the migration.