Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase_auth): TenantId can be reset to null after being set to something else #7897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rexios80
Copy link
Contributor

Description

Existing behavior

  • Cannot set tenantId to null after setting it to something else

New behavior

  • Setting tenantId back to null works as expected

Motivation

  • This is how the native SDKs work

I was unsure how to write tests for this. The existing tenantId tests don't look like they actually interact with the platform code. If anyone could point me in the right direction I would be happy to write them.

Related Issues

#7896 (comment)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Rexios80 Rexios80 changed the title TenantId can be reset to null after being set to something else fix(firebase_auth): TenantId can be reset to null after being set to something else Jan 18, 2022
@Rexios80 Rexios80 marked this pull request as draft January 18, 2022 16:56
@Rexios80
Copy link
Contributor Author

Rexios80 commented Jan 18, 2022

Welp it looks like this issue goes deeper than just this plugin

In the native Android SDK:

    public void setTenantId(@NonNull String param1) {
        // $FF: Couldn't be decompiled
    }

I don't think that code is open source, so I'm stuck on this. I definitely think you're supposed to be able to set the tenantId back to null. The iOS and web SDKs let you, and the value defaults to null anyways.

@Rexios80 Rexios80 marked this pull request as ready for review January 18, 2022 17:22
@russellwheatley
Copy link
Member

Hey @Rexios80, this is worth raising on the firebase-android-sdk I believe. It looks like it probably shouldn't be @nonnull annotated but worth finding out what folks on that repo think 😄.

@Salakar
Copy link
Member

Salakar commented Feb 8, 2022

@Rexios80 please let me know if you've raised an issue for this and we can mention it to the Android SDK devs

@Rexios80
Copy link
Contributor Author

Rexios80 commented Feb 8, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants