Skip to content

Update quickstars/email-users #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2017
Merged

Update quickstars/email-users #197

merged 2 commits into from
Jul 24, 2017

Conversation

PaulRBerg
Copy link

@PaulRBerg PaulRBerg commented Jul 23, 2017

The last version(2.4.1) of nodemailer is officially deprecated, so I added 4.0.1.

screen shot 2017-07-23 at 12 03 54

Did this to ensure the functionality. Furthermore, tried to run the project, but didn't work until I altered the firebase.json file by changing the path from "public" to "./public". Otherwise, the hosting website wouldn't be found.

The last version(2.4.1) is officially deprecated.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@PaulRBerg PaulRBerg changed the title Update package.json Update quickstars/email-users/functions/package.json Jul 23, 2017
@PaulRBerg
Copy link
Author

Signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

@PaulRBerg PaulRBerg changed the title Update quickstars/email-users/functions/package.json Update quickstars/email-users Jul 23, 2017
@nicolasgarnier
Copy link
Contributor

Thanks @PaulRBerg

@nicolasgarnier nicolasgarnier merged commit 33721eb into firebase:master Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants