Skip to content

Revert "Revert "[Infra] Embed frameworks scripts/add_framework_script.rb"" #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncooke3 merged 2 commits into from
Apr 26, 2024
Merged

Revert "Revert "[Infra] Embed frameworks scripts/add_framework_script.rb"" #1578

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9373456
Revert "Revert "[Infra] Embed frameworks `scripts/add_framework_scrip…
ncooke3 Apr 26, 2024
5132652
Embed and link
ncooke3 Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions scripts/add_framework_script.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,13 @@
project = Xcodeproj::Project.open(project_path)
project_framework_group = project.frameworks_group

def add_ref(group, path, source_tree, phase)
def add_ref(group, path, source_tree, phase_list)
ref = group.new_reference("#{path}")
ref.name = "#{File.basename(path)}"
ref.source_tree = source_tree
phase.add_file_reference(ref)
phase_list.each do |phase|
phase.add_file_reference(ref)
end
puts ref
end

Expand All @@ -53,7 +55,7 @@ def add_ref(group, path, source_tree, phase)
add_ref(project.main_group,
framework_path,
source_tree,
project_target.resources_build_phase)
[project_target.resources_build_phase])
end
else
framework_group = Dir.glob(File.join(framework_path, "*.{#{file_ext}}"))
Expand All @@ -62,12 +64,13 @@ def add_ref(group, path, source_tree, phase)
next unless project_target.name == target
framework_set = project_target.frameworks_build_phase.files.to_set
puts "The following frameworks are added to #{project_target}"
embed_frameworks_phase = project_target.new_copy_files_build_phase("Embed Frameworks")
framework_group.each do |framework|
next if framework_set.size == framework_set.add(framework).size
add_ref(project_framework_group,
framework,
source_tree,
project_target.frameworks_build_phase)
[project_target.frameworks_build_phase, embed_frameworks_phase])
end
end
end
Expand All @@ -78,7 +81,7 @@ def add_ref(group, path, source_tree, phase)
add_ref(project_framework_group,
framework_path,
source_tree,
project_target.frameworks_build_phase)
[project_target.frameworks_build_phase])
end
end
project.save()