-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Infra] Upgrade to FirebaseUI v15 #1725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've updated the FirebaseUI
dependency across the database
, firestore
, and functions
example projects to version 15.0. This upgrade is critical as it resolves issues preventing the firebase-ios-sdk
prerelease and release workflows from passing, ensuring the stability and progress of our CI/CD pipelines. The changes primarily involve updating CocoaPods specifications and their corresponding lock files.
Highlights
- FirebaseUI Version Upgrade: I've upgraded the
FirebaseUI
dependency across thedatabase
,firestore
, andfunctions
example projects from version~> 14.0
to~> 15.0
in their respectivePodfile
configurations. - Dependency Lock File Updates: The
Podfile.lock
files for each affected project have been updated to reflect the newFirebaseUI
component versions (e.g.,FirebaseDatabaseUI
to15.1.0
,FirebaseAuthUI
to15.1.0
,FirebaseEmailAuthUI
to15.1.0
,FirebaseGoogleAuthUI
to15.1.0
). These updates also include adjustments to transitive dependency version constraints, such asFirebaseAuth
andFirebaseDatabase
. - GoogleSignIn and AppCheckCore Integration: Specifically within the
functions/LegacyFunctionsQuickstart
project, theGoogleSignIn
dependency has been upgraded from7.1.0
to8.0.0
, which in turn introducesAppCheckCore
as a new required dependency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades FirebaseUI from version 14 to 15 across multiple example projects. It's recommended to test the application to ensure compatibility with the new versions.
@@ -6,7 +6,7 @@ platform :ios, '15.0' | |||
def firebase_pods | |||
pod 'FirebaseAuth' | |||
pod 'FirebaseDatabase' | |||
pod 'FirebaseUI/Database', '~> 14.0' | |||
pod 'FirebaseUI/Database', '~> 15.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pod 'FirebaseUI/Auth', '~> 15.0' | ||
pod 'FirebaseUI/Email', '~> 15.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pod 'FirebaseUI/Auth', '~> 15.0' | ||
pod 'FirebaseUI/Google', '~> 15.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to access tokens, but the only thing keeping firebase-ios-sdk
prerelease
andrelease
workflows from passing at this point.