Skip to content

[Infra] Upgrade to FirebaseUI v15 #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

[Infra] Upgrade to FirebaseUI v15 #1725

merged 1 commit into from
Jul 3, 2025

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Jul 3, 2025

Unrelated to access tokens, but the only thing keeping firebase-ios-sdk prerelease and release workflows from passing at this point.

@ncooke3 ncooke3 requested a review from andrewheard July 3, 2025 21:34
@ncooke3 ncooke3 enabled auto-merge July 3, 2025 21:34
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ncooke3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've updated the FirebaseUI dependency across the database, firestore, and functions example projects to version 15.0. This upgrade is critical as it resolves issues preventing the firebase-ios-sdk prerelease and release workflows from passing, ensuring the stability and progress of our CI/CD pipelines. The changes primarily involve updating CocoaPods specifications and their corresponding lock files.

Highlights

  • FirebaseUI Version Upgrade: I've upgraded the FirebaseUI dependency across the database, firestore, and functions example projects from version ~> 14.0 to ~> 15.0 in their respective Podfile configurations.
  • Dependency Lock File Updates: The Podfile.lock files for each affected project have been updated to reflect the new FirebaseUI component versions (e.g., FirebaseDatabaseUI to 15.1.0, FirebaseAuthUI to 15.1.0, FirebaseEmailAuthUI to 15.1.0, FirebaseGoogleAuthUI to 15.1.0). These updates also include adjustments to transitive dependency version constraints, such as FirebaseAuth and FirebaseDatabase.
  • GoogleSignIn and AppCheckCore Integration: Specifically within the functions/LegacyFunctionsQuickstart project, the GoogleSignIn dependency has been upgraded from 7.1.0 to 8.0.0, which in turn introduces AppCheckCore as a new required dependency.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades FirebaseUI from version 14 to 15 across multiple example projects. It's recommended to test the application to ensure compatibility with the new versions.

@@ -6,7 +6,7 @@ platform :ios, '15.0'
def firebase_pods
pod 'FirebaseAuth'
pod 'FirebaseDatabase'
pod 'FirebaseUI/Database', '~> 14.0'
pod 'FirebaseUI/Database', '~> 15.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This pull request updates the FirebaseUI/Database dependency to version 15. Consider testing the application to ensure compatibility with the new version.

Comment on lines +7 to +8
pod 'FirebaseUI/Auth', '~> 15.0'
pod 'FirebaseUI/Email', '~> 15.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This pull request updates the FirebaseUI/Auth and FirebaseUI/Email dependencies to version 15. Consider testing the application to ensure compatibility with the new versions.

Comment on lines +8 to +9
pod 'FirebaseUI/Auth', '~> 15.0'
pod 'FirebaseUI/Google', '~> 15.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This pull request updates the FirebaseUI/Auth and FirebaseUI/Google dependencies to version 15. Consider testing the application to ensure compatibility with the new versions.

@ncooke3 ncooke3 merged commit c974bcd into main Jul 3, 2025
13 checks passed
@ncooke3 ncooke3 deleted the nc/podfiles branch July 3, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants