query correct metric for diff snapshots in snap creation perf test #5272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have different metrics for snapshot creation latency for full and diff snapshots (why? Good question), so if we're measuring diff snapshot creation latency we need to query diff_create_snapshot instead of full_create_snapshot. Just inline this logic into the test instead of adding a property to SnapshotType because there is literally no other use of this pattern in our tests (if there ever will be, which I doubt, we can still abstract it away). Signed-off-by: Patrick Roy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5272 +/- ##
==========================================
+ Coverage 82.84% 82.90% +0.05%
==========================================
Files 250 250
Lines 26967 26967
==========================================
+ Hits 22342 22356 +14
+ Misses 4625 4611 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roypat
added
the
Status: Awaiting review
Manciukic
approved these changes
Jun 19, 2025
kalyazin
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have different metrics for snapshot creation latency for full and diff snapshots (why? Good question), so if we're measuring diff snapshot creation latency we need to query diff_create_snapshot instead of full_create_snapshot.
Just inline this logic into the test instead of adding a property to SnapshotType because there is literally no other use of this pattern in our tests (if there ever will be, which I doubt, we can still abstract it away).
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.