tests: add periodic sanitizer integration test pipeline#5722
Open
aaron-ang wants to merge 1 commit intofirecracker-microvm:mainfrom
Open
tests: add periodic sanitizer integration test pipeline#5722aaron-ang wants to merge 1 commit intofirecracker-microvm:mainfrom
aaron-ang wants to merge 1 commit intofirecracker-microvm:mainfrom
Conversation
cb7bf19 to
34ee078
Compare
Add a dedicated integration test that runs vmm Rust integration tests under ASAN, and wire a Buildkite pipeline generator for periodic sanitizer runs. Also document the run command and harden tools/test.sh for local runs under set -u by guarding BUILDKITE variable access. Signed-off-by: Aaron Ang <aaron.angyd@gmail.com>
34ee078 to
4de013b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
tests/integration_tests/build/test_sanitizers.pyto run Rustvmmintegration tests under ASAN (address) as anoncibuild test..buildkite/pipeline_sanitizers.pyto generate Buildkite sanitizer steps per architecture (m6i.metal,m7g.metal).tests/README.mdwith sanitizer test run instructions and pipeline reference.tools/test.shto avoid unbound-variable failure outside Buildkite by changing"$BUILDKITE"to"${BUILDKITE:-false}".Reason
Closes #1662.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.N/A: this PR does not introduce user-facing behavior changes.
Runbook for Firecracker API changes.
N/A: this PR does not make API changes.
integration tests.
TODO.rust-vmm.