Bring across updates to FML in Gusto to the FML branch #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDBetteridge
pushed a commit
that referenced
this pull request
Aug 11, 2023
* port FML changes from gusto * update docstring style * fix lint and docstring issues
JDBetteridge
pushed a commit
that referenced
this pull request
Sep 22, 2023
* port FML changes from gusto * update docstring style * fix lint and docstring issues
JDBetteridge
pushed a commit
that referenced
this pull request
Oct 5, 2023
* port FML changes from gusto * update docstring style * fix lint and docstring issues
JDBetteridge
pushed a commit
that referenced
this pull request
Oct 9, 2023
* port FML changes from gusto * update docstring style * fix lint and docstring issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings across changes made to the Gusto implementation of FML, following last week's Firedrake meeting.
It also updates references from
gusto.fmltofiredrake.fml. The tests will hopefully all pass now (with one exception...)This is linked to FEniCS/UFL PR 184 (FEniCS/ufl#184) -- the
test_replace_perpwill fail until we pick up the new perp operator in UFL.