Use getSampleIndexToCallNodeIndexForPreviewFilteredThread.

firefox-devtools · Jan 22, 2024 · cd5e534 · cd5e534
1 parent 2d1004b
commit cd5e534
Showing 1 changed file with 13 additions and 12 deletions.
diff --git a/src/selectors/per-thread/stack-sample.js b/src/selectors/per-thread/stack-sample.js
@@ -234,6 +234,15 @@ export function getStackAndSampleSelectorsPerThread(
       )
   );
 
+  const getSampleIndexToCallNodeIndexForPreviewFilteredThread: Selector<
+    Array<IndexIntoCallNodeTable | null>,
+  > = createSelector(
+    (state) =>
+      threadSelectors.getPreviewFilteredSamplesForCallTree(state).stack,
+    (state) => getCallNodeInfo(state).getStackIndexToCallNodeIndex(),
+    ProfileData.getSampleIndexToCallNodeIndex
+  );
+
   const getSampleIndexToCallNodeIndexForTabFilteredThread: Selector<
     Array<IndexIntoCallNodeTable | null>,
   > = createSelector(
@@ -302,13 +311,9 @@ export function getStackAndSampleSelectorsPerThread(
 
   const getCallTreeTimings: Selector<CallTree.CallTreeTimings> = createSelector(
     threadSelectors.getPreviewFilteredSamplesForCallTree,
+    getSampleIndexToCallNodeIndexForPreviewFilteredThread,
     getCallNodeInfo,
-    (samples, callNodeInfo) => {
-      const sampleIndexToCallNodeIndex =
-        ProfileData.getSampleIndexToCallNodeIndex(
-          samples.stack,
-          callNodeInfo.getStackIndexToCallNodeIndex()
-        );
+    (samples, sampleIndexToCallNodeIndex, callNodeInfo) => {
       const callNodeLeafAndSummary = CallTree.computeCallNodeLeafAndSummary(
         samples,
         sampleIndexToCallNodeIndex,
@@ -346,14 +351,10 @@ export function getStackAndSampleSelectorsPerThread(
   const getTracedTiming: Selector<CallTree.CallTreeTimings | null> =
     createSelector(
       threadSelectors.getPreviewFilteredSamplesForCallTree,
+      getSampleIndexToCallNodeIndexForPreviewFilteredThread,
       getCallNodeInfo,
       ProfileSelectors.getProfileInterval,
-      (samples, callNodeInfo, interval) => {
-        const sampleIndexToCallNodeIndex =
-          ProfileData.getSampleIndexToCallNodeIndex(
-            samples.stack,
-            callNodeInfo.getStackIndexToCallNodeIndex()
-          );
+      (samples, sampleIndexToCallNodeIndex, callNodeInfo, interval) => {
         const callNodeLeafAndSummary =
           CallTree.computeCallNodeTracedLeafAndSummary(
             samples,