Alpacino767/issue #2654 #4968
Alpacino767/issue #2654 #4968
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4968 +/- ##
=======================================
Coverage 88.45% 88.46%
=======================================
Files 304 304
Lines 27317 27326 +9
Branches 7377 7379 +2
=======================================
+ Hits 24164 24173 +9
Misses 2931 2931
Partials 222 222 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Hey, thanks for your patch!
I realize I never pushed the review even though I wrote it a long time ago, I'm so sorry about that. So here is the review. I hope you'll still want to look at it, but otherwise that's fine too, just tell me.
Thanks again for your time
| @@ -249,6 +250,8 @@ class HomeImpl extends React.PureComponent<HomeProps, HomeState> { | |||
| this.setState({ popupInstallPhase: 'webchannel-unavailable' }); | |||
| } | |||
| ); | |||
| } else if (isMobile()) { | |||
There was a problem hiding this comment.
The check for isMobile should be inside the isFirefox block, because we want to check for Firefox Android specifically.
In the code you wrote, if the browser is Firefox (desktop or android) we never go to the "else", so this is exactly the opposite to what we want here.
PR for issue #2654