Take in account the capability to get default attribute options. $type was not …

[sylvainraye]

…provided into the method _getCombinedKey

[Flyingmana]

looks fine for me

[quafzi]

@diglin @Flyingmana Thank you!

I'm still looking for a new maintainer of this module. It would be great to turn it into a Firegento module, therefore I already adapted the Firegento coding style rules in firegento branch. Previous contributors already agreed to license change in #9. Anyone interested?

[Flyingmana]

@quafzi if Firegento does not work out, I still offer to take the maintaining over as part of @Cotya

[sylvainraye]

@therouv is one of the person who can confirm that or not. I use your module very often so I could be the maintainer. I have also a module which waits to be confirmed for a Firegento namespace changes

[therouv]

I'd vote for a move to FireGento namespace because I think this module would be a great addition.

I have some questions/remarks though which I will post (probably/at the latest) Wednesday (public holiday in Germany).

[therouv]

Hi @quafzi great module, thanks!
My questions/remarks:

• With which Magento versions is this module supposed to work? We should add a hint in the README with the supported versions.
  • Ideally there will be tests for all changes and let travis build for different Magento/PHP versions.
• The Branch firegento should be updated with the latest changes from master branch.
• License file in firegento branch should be updated to GPL as well.