-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cyclic concurrent buildings of vite and hugo while both in watching mode #1751
Open
Convolutio
wants to merge
49
commits into
fireship-io:master
Choose a base branch
from
Convolutio:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this button has its style to be enhanced the initial page loading is not with the saved theme
TODO: enhance the css maintainability TODO: fix the logo layout TODO: make prettier the dark mode button
todo: keep user authentication on static page refresh
this error made supabase unable to finish its API request promises fixed with reloading the session at each supabase-app mounting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
npm start
is run,vite build
is watching wrong directories in which files are edited by the finalhugo
buildingserver, launching a new build from
vite
, then a new build fromhugo
, and so on. This is unusable for an edition of the layout files or the style sheets with real-time rendering because the website is uselessly reloaded too much frequently.With this fix,
vite
rebuilds the website only if useful files are edited, i.e. files in theapp
,layout
orstyle
directories.