Ledger device tx sign fix

[levoncrypto]

Summary by CodeRabbit

• Refactor

  • Optimized the getTrustedInput method for better handling of transaction.extra_data.
  • Enhanced the perform_hw1_preflight method to set an additional coin version.
  • Updated the sign_transaction method to support an extra address type (ADDRTYPE_EXP2PKH).

• Bug Fixes

  • Removed exception raise for exceeding DIP2 extra data block size limit in getTrustedInput.

[coderabbitai]

Walkthrough

The recent updates to ledger.py in the electrum_dash/plugins/ledger module include optimizing the handling of transaction.extra_data, adding a new coin version in hardware preflight checks, and supporting an additional address type during transaction signing. Additionally, an exception for exceeding DIP2 extra data block size has been removed for improved functionality.

Changes

File	Change Summary
electrum_dash/plugins/ledger/ledger.py	Refactored getTrustedInput for efficiency, enhanced perform_hw1_preflight with a new coin version, and updated sign_transaction for an extra address type. Removed DIP2 extra data block size exception in getTrustedInput.

Poem

Hop along the code so bright,
With changes new, the future's light.
Extra data, now so clear,
Transactions swift, with zero fear.
A coin version, address type—
The ledger's dance, a coder's hype! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e3bd997 and d8ece9a.

Files selected for processing (1)

• electrum_dash/plugins/ledger/ledger.py (3 hunks)

Additional comments not posted (6)

electrum_dash/plugins/ledger/ledger.py (6)

140-144: Efficient handling of transaction.extra_data.

The added code efficiently handles transaction.extra_data by checking its presence and writing its length and content into params.

---

145-148: Correct APDU command update.

The APDU command is correctly updated to include the length of transaction.lockTime and params.

---

Line range hint 282-286:
Setting additional coin version.

The additional coin version is correctly set using setAlternateCoinVersions with constants.net.ADDRTYPE_EXP2PKH.

---

521-523: Handling extra address type.

The code correctly handles the extra address type (constants.net.ADDRTYPE_EXP2PKH) by converting it to the appropriate address format.

---

140-144: Efficient handling of transaction.extra_data.

The added code efficiently handles transaction.extra_data by checking its presence and writing its length and content into params.

---

145-148: Correct APDU command update.

The APDU command is correctly updated to include the length of transaction.lockTime and params.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d8ece9a and b44083d.

Files selected for processing (1)

• electrum_dash/plugins/ledger/ledger.py (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• electrum_dash/plugins/ledger/ledger.py