Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Redis-backed queues do not consume further messages once a queue is empty #168

Merged
merged 6 commits into from
Sep 26, 2024

Conversation

soharab-ic
Copy link
Contributor

  • Redis LPop command does not wait for new messages.
  • Redis BLPop command is blocking version of LPop command and it blocks the connection when there are no elements to pop from the list.
  • Use BLPop for redis-http-connector instead of LPop.

Fixes #159

* LPop does not wait for new messages.
* Use BLPop which is blocking version for LPop and waits for new messages.

Signed-off-by: Md Soharab Ansari <[email protected]>
@sanketsudake
Copy link
Member

@soharab-ic can you confirm if we can reproduce #159 and have cross verified fix with the same ?

@soharab-ic
Copy link
Contributor Author

@soharab-ic can you confirm if we can reproduce #159 and have cross verified fix with the same ?

Yes @sanketsudake, I reproduced the issue #159 and then verified the fix with the same.

@sanketsudake sanketsudake merged commit b4b8853 into main Sep 26, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis-backed queues do not consume further messages once a queue is empty
2 participants