Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs, model updates, add tests, add documentation #16

Merged
merged 7 commits into from
Oct 29, 2024

Conversation

fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Oct 2, 2024

PR Overview

This PR will address the following Issue/Feature:
Adding conversion metrics

This PR will result in the following new package version:

v0.4.0

breaking change to users who weren't bringing in conversion metrics already through the passthrough variable.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

Feature update: Conversions Support

  • We have added conversion metrics to the end models.

  • The conversion metrics are the following:

    • purchases_30_d: Number of attributed conversion events occurring within 30 days of an ad click.
    • sales_30_d: Total value of sales occurring within 30 days of an ad click.
  • In the event that you were already passing the above fields in via our passthrough columns, the package will dynamically avoid "duplicate column" errors.

The above new field additions are 🚨 breaking changes 🚨 for users who were not already bringing in conversion fields via passthrough columns.

Under the Hood

  • Created amazon_ads_persist_pass_through_columns macro to ensure that the new conversion fields are backwards compatible with users who have already included them via passthrough fields.
  • Added integrity and consistency validation tests within integration_tests folder for the transformation models (to be used by maintainers only).

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • [na] The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Validation tests passing

If you had to summarize this PR in an emoji, which would it be?

💃

Copy link
Collaborator

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

integration_tests/tests/integrity/vertical_sum_conversions Outdated Show resolved Hide resolved
packages.yml Outdated
Comment on lines 2 to 7
# - package: fivetran/amazon_ads_source
# version: [">=0.4.0", "<0.5.0"]

- git: https://github.com/fivetran/dbt_amazon_ads_source.git
revision: feature/conversions
warn-unpinned: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to swap before release

@fivetran-jamie fivetran-jamie merged commit fc762c0 into main Oct 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants