docs, model updates, add tests, add documentation#16
Merged
fivetran-jamie merged 7 commits intomainfrom Oct 29, 2024
Merged
Conversation
fivetran-joemarkiewicz
approved these changes
Oct 28, 2024
packages.yml
Outdated
Comment on lines
2
to
7
| # - package: fivetran/amazon_ads_source | ||
| # version: [">=0.4.0", "<0.5.0"] | ||
|
|
||
| - git: https://github.com/fivetran/dbt_amazon_ads_source.git | ||
| revision: feature/conversions | ||
| warn-unpinned: false No newline at end of file |
Collaborator
There was a problem hiding this comment.
Reminder to swap before release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature:
Adding conversion metrics
This PR will result in the following new package version:
v0.4.0
breaking change to users who weren't bringing in conversion metrics already through the passthrough variable.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Feature update: Conversions Support
We have added conversion metrics to the end models.
The conversion metrics are the following:
purchases_30_d: Number of attributed conversion events occurring within 30 days of an ad click.sales_30_d: Total value of sales occurring within 30 days of an ad click.In the event that you were already passing the above fields in via our passthrough columns, the package will dynamically avoid "duplicate column" errors.
Under the Hood
amazon_ads_persist_pass_through_columnsmacro to ensure that the new conversion fields are backwards compatible with users who have already included them via passthrough fields.integration_testsfolder for the transformation models (to be used by maintainers only).PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Validation tests passing
If you had to summarize this PR in an emoji, which would it be?
💃