検索結果一覧を非React化した #8203
Draft
検索結果一覧を非React化した #8203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nakamu-kazu222
force-pushed
the
feature/change-searchables-not-react
branch
from
71d671b to
542291e
Compare
nakamu-kazu222
force-pushed
the
feature/change-searchables-not-react
branch
from
d5c474d to
d33ddcd
Compare
nakamu-kazu222
force-pushed
the
feature/change-searchables-not-react
branch
from
d33ddcd to
3d3e414
Compare
nakamu-kazu222
force-pushed
the
feature/change-searchables-not-react
branch
from
f79c125 to
13d7d09
Compare
nakamu-kazu222
force-pushed
the
feature/change-searchables-not-react
branch
2 times, most recently
from
444ed93 to
7046d46
Compare
投稿の種類のラベル、タイトル、summary、ユーザーのアイコン、ユーザー名、更新時間
投稿の幅をそろえた
また、ロード遅延のためOpenStruct.new(を廃止した
エラー内容：ActionController::UrlGenerationError in Users#show
No route matches {:action=>"show", :controller=>"talks", :id=>nil}, possible unmatched constraints: [:id]
searchable_urlでコメントのもとのモデルのpathを参照できるようにした
current_userを渡すようにした
「マルマル シャインカ」のようなスペースを含む検索ワードがそのまま1つの文字列として扱われ、部分一致検索ができるようにした
nakamu-kazu222
force-pushed
the
feature/change-searchables-not-react
branch
from
0c193c1 to
9938ba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
概要
変更確認方法
Screenshot
変更前
変更後