-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FBC内の分報の削除・編集機能の追加 #8362
Draft
SuzukiShuntarou
wants to merge
27
commits into
main
Choose a base branch
from
feature/update-and-delete-about-micro-reports
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
FBC内の分報の削除・編集機能の追加 #8362
SuzukiShuntarou
wants to merge
27
commits into
main
from
feature/update-and-delete-about-micro-reports
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49cf350
to
5486cf9
Compare
5486cf9
to
cf620a7
Compare
@SuzukiShuntarou 一旦、一覧の方のデザインを更新しましたー。デザインを更新してJSが動かなくなってしまったので、動くようにしていただきたいです。 そのときに、既存のclassを使ってJSを発火させるのではなく、js-xxxx という js プリフィクスを付けた新しいクラスを使って発火させるようにして、デザインとjsを分離するようにしていただきたいです🙏 |
お手数をおかけしますが、再度ご対応をどうぞよろしくお願いいたします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
概要
分報の新規作成、表示は別のPRで実装済。(本番環境では分報タブを非表示にしている)
変更確認方法
feature/update-and-delete-about-micro-reports
をローカルに取り込むgit fetch origin feature/update-and-delete-about-micro-reports
git checkout feature/update-and-delete-about-micro-reports
rails db:seed
を実行して動作確認用の分報の初期データを追加する。foreman start -f Procfile.dev
でローカル環境を立ち上げる。hajime
パスワードtesttest
でログインする。komagata
パスワードtesttest
でログインする。(adminユーザ)hajime
を入力して検索し、プロフィールを表示する。mentormentaro
パスワードtesttest
でログインする。(非adminユーザ)hajime
を入力して検索し、プロフィールを表示する。Screenshot
変更前
変更後
作成者、または、adminユーザの場合、【内容修正】と【削除】の追加

【内容修正】を押すと、【コメント】【プレビュー】タブの表示


作成者でない、かつ、非adminユーザは【内容修正】と【削除】が表示されない
