feat: Update HTTP status codes for unauthorized requests #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes update the HTTP status codes returned when a user is unauthorized to perform an action. Previously, the code was returning a 500 Internal Server Error, which is not the correct response for an unauthorized request. The changes update the status codes to 401 Unauthorized, which is the appropriate response for an unauthorized request. The changes were made to the following files: - `internal/company/http.go` - `internal/secretmenu/http.go` - `internal/project/http.go` - `internal/agent/http.go` - `internal/user/http.go` - `internal/environment/http.go` This ensures that the API is returning the correct HTTP status codes for unauthorized requests, which is important for client-side error handling and debugging.
Qodana for GoIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes update the HTTP status codes returned when a user is unauthorized to perform an action. Previously, the code was returning a 500 Internal Server Error, which is not the correct response for an unauthorized request. The changes update the status codes to 401 Unauthorized, which is the appropriate response for an unauthorized request.
The changes were made to the following files:
internal/company/http.gointernal/secretmenu/http.gointernal/project/http.gointernal/agent/http.gointernal/user/http.gointernal/environment/http.goThis ensures that the API is returning the correct HTTP status codes for unauthorized requests, which is important for client-side error handling and debugging.