docs: Deprecate TapDetector in favour of TapCallbacks #2886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
spydon
added a commit
that referenced
this pull request
Dec 1, 2023
Update t-rex game to use `TapCallbacks` instead of `TapDetector`, in anticipation of [deprecating the latter](#2886). Also update the term high score to avoid a dictionary entry. Co-authored-by: Lukas Klingsbo <[email protected]>
|
@luanpotter what were our concerns here again? I think it would be great to only have |
|
@spydon see my design doc for complete breakdown |
Where is the design doc? Would be good to have that linked here so that we can have a look at it every 6 months after we've forgotten what it's about. 😄 |
|
@spydon should I reactivate this now that we have agreed on moving forward with this? |
Did you get a green light from @erickzanardo too? Because I think he was the one that was sceptical. Otherwise it sounds good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecate
TapDetectorin favour ofTapCallbacksChecklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?