Skip to content

docs: Deprecate TapDetector in favour of TapCallbacks#2886

Merged
luanpotter merged 9 commits intomainfrom
luan.events-1
Oct 2, 2025
Merged

docs: Deprecate TapDetector in favour of TapCallbacks#2886
luanpotter merged 9 commits intomainfrom
luan.events-1

Conversation

@luanpotter
Copy link
Member

@luanpotter luanpotter commented Dec 1, 2023

Description

Deprecate TapDetector in favour of TapCallbacks

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter marked this pull request as draft December 1, 2023 04:41
@luanpotter luanpotter mentioned this pull request Dec 1, 2023
Merged
6 tasks
spydon added a commit that referenced this pull request Dec 1, 2023
@luanpotter @spydon
docs: Update t-rex game to use TapCallbacks (#2888)
81930e2 
Update t-rex game to use `TapCallbacks` instead of `TapDetector`, in
anticipation of [deprecating the
latter](#2886).

Also update the term high score to avoid a dictionary entry.

Co-authored-by: Lukas Klingsbo <[email protected]>
@spydon
Copy link
Member

spydon commented Dec 17, 2024

@luanpotter what were our concerns here again? I think it would be great to only have TapCallbacks.

@luanpotter
Copy link
Member Author

luanpotter commented Apr 2, 2025

@spydon see my design doc for complete breakdown

@spydon
Copy link
Member

spydon commented Apr 2, 2025

@spydon see my design doc for complete breakdown

Where is the design doc? Would be good to have that linked here so that we can have a look at it every 6 months after we've forgotten what it's about. 😄

@luanpotter
Copy link
Member Author

luanpotter commented Apr 3, 2025

Flame: Event System

@luanpotter
Copy link
Member Author

luanpotter commented Apr 22, 2025

@spydon should I reactivate this now that we have agreed on moving forward with this?

@spydon
Copy link
Member

spydon commented Apr 22, 2025

@spydon should I reactivate this now that we have agreed on moving forward with this?

Did you get a green light from @erickzanardo too? Because I think he was the one that was sceptical. Otherwise it sounds good to me!

@luanpotter luanpotter marked this pull request as ready for review September 27, 2025 23:14
@luanpotter
Copy link
Member Author

luanpotter commented Sep 27, 2025

@spydon @erickzanardo are we able to finally move forward with this and kickstart the event system migration as outlined on my doc?

@luanpotter
Copy link
Member Author

luanpotter commented Sep 27, 2025

lmk if we prefer to split the fixes into a separate pr first - I didn't realize the old system was used so much across the codebase

@luanpotter luanpotter requested a review from a team September 28, 2025 01:17
@spydon
Copy link
Member

spydon commented Sep 28, 2025

@spydon @erickzanardo are we able to finally move forward with this and kickstart the event system migration as outlined on my doc?

Sure, let's go!
I don't think we need to split up the PR.

spydon
spydon approved these changes Oct 2, 2025
View reviewed changes
Copy link
Member

@spydon spydon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onTap = onTapUp, not onTapDown, but I don't think it matters.

@luanpotter
Copy link
Member Author

luanpotter commented Oct 2, 2025

@spydon - @renancaraujo has very strong opinions on whether games should use tap up or tap down listeners, but I always forget what is the "standard". I will let him follow up unifying all examples that don't care to his preferred standard :)

@luanpotter luanpotter enabled auto-merge (squash) October 2, 2025 20:14
@luanpotter luanpotter merged commit b173697 into main Oct 2, 2025
67 checks passed
@luanpotter luanpotter deleted the luan.events-1 branch October 2, 2025 20:21
nickf2k pushed a commit to nickf2k/flame that referenced this pull request Nov 16, 2025
@luanpotter @vuong3-nguyen
docs: Deprecate TapDetector in favour of TapCallbacks (flame-engine#2886
e5938aa 
)

Deprecate `TapDetector` in favour of `TapCallbacks`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spydon spydon spydon approved these changes

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luanpotter @spydon @erickzanardo