fix: Ray direction normalization drift issues#3841
Merged
Conversation
…tersection calculations
spydon
reviewed
Mar 4, 2026
spydon
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
raytrace()reuses the sameRaycastResultobjects across bounces, so the reflected direction from one bounce becomes the incident direction for the next.Vector2.reflect()is not bit-exact, so each bounce introduces a tiny floating-point rounding error. After enough bounces the direction's length drifts just past the1e-6tolerance thatRay2enforces, causing adirection must be normalizedassertion crash.Two fixes:
CircleHitboxandPolygonRayIntersection(used byRectangleHitbox/PolygonHitbox): callnormalize()on the reflected direction before passing it toRay2, so drift is corrected on every bounce.raytrace_example: the initial ray direction was set via a cascade on theVector2getter (ray.direction..setValues(...)), which bypasses thedirection=setter and leaves the cached inverse values stale. Fixed to assign through the setter.Regression tests are included that inject a direction whose length² is already above the threshold (by writing directly to the underlying
Vector2, bypassing the setter), then assert thatraycast()does not throw.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues