Fix for aspect ratio losing ratio #3439
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that the ratio was being calculated on every "tick" of movement instead of keeping it. So every pixel moved, a new ratio was calculated which is not the user's intent. This way, the ratio is kept while the user is resizing the image and tries to minimize the rounding issues. Rounding issues still exist but they are now only minimal on at what is highest of the ratio.
brunoais
force-pushed
the
#3436_fixKeepAspectRatio
branch
from
401be4d to
eddbcca
Compare
| bool symmetryMod = qApp->keyboardModifiers() & Qt::ShiftModifier; | ||
| bool preserveAspect = qApp->keyboardModifiers() & Qt::ControlModifier; | ||
| if(aspectRatio < 0 || ! preserveAspect){ |
There was a problem hiding this comment.
whats the reason for checking if the aspectRatio is < 0?
There was a problem hiding this comment.
I think because of line 194, this if statement means "if the user have not forced certain aspect ratio (and if it is not marked to be preserved), then ..."
But based on what I can see, aspect ratio will always be -1.0 before this if. Unless in C++ the variables are not bound to the function scope and line 224 in changes the global value of the variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for aspect ratio losing ratio (bad code version)
The reason why it's bad code is because I'm using a global variable for this purpose and that is a really bad idea. Unfortunately, I don't know where can this information be stored.
Please help: The part I'm missing is somewhere to store the float variable. Once I have a suitable place, this PR is complete.
Note: I'm not used to C++ code, this is my first time working with C++ code without prior help, please be patient.
Fixes #3436