Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forum styles into basic.blade.php #5

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

mbakirov
Copy link

Changes proposed in this pull request:
Add forum styles into confirm email page would solve a bug that appears when the dark theme is turned on and theme was slightly customized.

For instance:

  • dark theme is on
  • primary color is set to #ffffff
  • secondary color is set to #151515

Screenshot
CleanShot 2025-02-17 at 15 55 30

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant