add a health-check server #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metachris
force-pushed
the
healthcheck-server
branch
2 times, most recently
from
589abdc to
dbe5a8f
Compare
metachris
force-pushed
the
healthcheck-server
branch
from
dbe5a8f to
2c955b2
Compare
MoeMahhouk
reviewed
Oct 10, 2024
| &cli.StringFlag{ | ||
| Name: "listen-addr-healthcheck", | ||
| EnvVars: []string{"LISTEN_ADDR_HEALTHCHECK"}, | ||
| Value: "", |
There was a problem hiding this comment.
should we also provide a default value for the health check similar to the other flags?
There was a problem hiding this comment.
i think it's better to make opt-in for now, instead of starting it by default.
cmd/proxy-server/main.go
Outdated
Comment on lines
47
to
48
| EnvVars: []string{"TLS_CERTIFICATE"}, | ||
| Usage: "Certificate to present (PEM). Only valid for --server-attestation-type=none and with --tls-private-key.", | ||
| Usage: "Path to TLS certificate (PEM). Only valid for --server-attestation-type=none and with --tls-private-key.", |
There was a problem hiding this comment.
nit: since the usage is now explicitly mentioning the path, should the env var name also be changed accordingly?
Like TLS_CERTIFICATE_FILE or TLS_CERTIFICATE_PATH
There was a problem hiding this comment.
yeah i guess that's right, but it'll need an update of our deployment too. better bite the bullet now though. updating
metachris
force-pushed
the
healthcheck-server
branch
from
1e99e43 to
f135be3
Compare
metachris
force-pushed
the
healthcheck-server
branch
from
f135be3 to
77078a3
Compare
Ruteri
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often, load balancers or kubernetes need to execute a health-check to the services. This would fail because it's not coming from a TDX instance. The solution is to spin up an optional additional server that responds 200 to requests.