Small fixes #32
Merged
Small fixes #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prior to this, building the image was causing this warning: ``` 1 warning found (use docker --debug to expand): - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 2) ```
this change causes docker to create an additional intermediate layer containing just the go.mod file and the downloaded dependencies cited therefrom. this prevents having to re-download the go.mod dependencies on EVERY image rebuild. more specifically, as long as you don't change the go.mod file, docker will use the cached layer.
it's used in the Makefile but, prior to this, the README didn't instruct you to install it.
metachris
approved these changes
Sep 20, 2024
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Small changes, as described in each commit message.
⛱ Motivation and Context
I put this repo to use and hit some friction along the way. These changes eliminate the friction that I experienced.
✅ I have run these commands
make lintmake testgo mod tidy