Skip to content

omaha: delete Cargo.lock #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Conversation

dongsupark
Copy link
Member

@dongsupark dongsupark commented Apr 8, 2025

Cargo lock file under the omaha workspace has been a blocker for some dependabot updates like idna as well as url.
Since all the dependancies are all being updated in the top-level lock file, it is not necessary to commit another lock file under the workspace.

Blocker of https://github.com/flatcar/ue-rs/security/dependabot/25.

Testing done

Local build passed

Cargo lock file under the omaha workspace has been a blocker for
some dependabot updates like idna as well as url. Since all the
dependancies are all being updated in the top-level lock file, it is
not necessary to commit another lock file under the workspace.
@John15321
Copy link
Member

@dongsupark I unfortunately cannot access https://github.com/flatcar/ue-rs/security/dependabot/25 :(

@dongsupark
Copy link
Member Author

@John15321 Thanks, I have just given admin access to all Flatcar maintainers, so you should be able to read the security issues.

@John15321 John15321 self-requested a review April 14, 2025 13:59
Copy link
Member

@John15321 John15321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@dongsupark dongsupark merged commit 1e17fe1 into trunk Apr 14, 2025
1 check passed
@dongsupark dongsupark deleted the dongsu/delete-omaha-cargolock branch April 14, 2025 15:43
dongsupark added a commit to flatcar/scripts that referenced this pull request Apr 23, 2025
Update coreos-base/ue-rs to 2025-04-23, mainly to fix security issues,
CVE-2024-12224 (GHSA-h97m-ww89-6jmq), GHSA-4fcv-w3qc-ppgg,
GHSA-rr8g-9fpq-6wmg.

Pulls in the following PRs:
* flatcar/ue-rs#60
* flatcar/ue-rs#61
* flatcar/ue-rs#62
* flatcar/ue-rs#64
dongsupark added a commit to flatcar/scripts that referenced this pull request Apr 23, 2025
Update coreos-base/ue-rs to 2025-04-23, mainly to fix security issues,
CVE-2024-12224 (GHSA-h97m-ww89-6jmq), GHSA-4fcv-w3qc-ppgg,
GHSA-rr8g-9fpq-6wmg.

Pulls in the following PRs:
* flatcar/ue-rs#60
* flatcar/ue-rs#61
* flatcar/ue-rs#62
* flatcar/ue-rs#64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants