Add support for Error.prototype.cause#296
Merged
Skn0tt merged 5 commits intoflightcontrolhq:mainfrom Sep 29, 2025
Merged
Conversation
Skn0tt
reviewed
Sep 17, 2024
Collaborator
Skn0tt
left a comment
There was a problem hiding this comment.
Thanks for the PR! Looks good generally, but please add some tests to convince me this works as intended.
Contributor
Author
Apologies @Skn0tt been rather side tracked on other work. Is the test I've added sufficient or would you like a more comprehensive set? For context we use electron-trpc and frequently pass |
|
@shortercode Thanks for making this PR as I'm encountering the same limitation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #294
Modifies the isDeep call to match Error objects, so that causes are correctly serialised.
Adds the cause field to serialised Error format and the deserialiser.