Reset nmod_poly_factor_t before writing to it #1603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the functions in
nmod_poly_factor
(sometimes) appended factors to the given factorization instead of replacing it. For example:The implementation of
nmod_poly_factor_kaltofen_shoup
assumed thatnmod_poly_factor_distinct_deg
appends the factors. I think either the documentation or the implementation ofnmod_poly_factor_distinct_deg
should be changed.For
nmod_poly_factor_equal_deg
, I think a reasonable interpretation of the documentation is that the factors are appended, so I didn't change the behavior.