Recognize Comet Lake U in config.guess #2074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On Monday, 23 September 2024 20:04:07 CEST Albin Ahlbäck wrote:
@mezzarobba could you check that this resolves #2073?
Almost: it should be 0xa6, not 0x8e. Thanks for looking into it!
…--
Marc
|
albinahlback
force-pushed
the
comet_lake_u
branch
from
fd43748 to
4ce49ce
Compare
|
Corrected to |
|
On Monday, 23 September 2024 21:33:52 CEST Albin Ahlbäck wrote:
Corrected to `0xa6`. I have previously taken everything from
https://en.wikichip.org/wiki/intel/cpuid as Intel do not seem to
document these things for the public (at least I have a hard time
finding this stuff). Anyway, give it a try!
Yes, it works now, thanks! I do get a warning that
```
/usr/bin/ld: warning: build/mpn_extras/x86_64/broadwell/
sqrhigh_normalised_hard.lo: missing .note.GNU-stack section implies
executable stack
/usr/bin/ld: NOTE: This behaviour is deprecated and will be removed in a
future version of the linker
Building libflint.so.20.0.0
/usr/bin/ld: warning: build/mpn_extras_merged.lo: requires executable
stack (because the .note.GNU-stack section is executable)
```
but I guess that's a different issue.
|
|
Yeah, seems like an opt-in in ld (source). I'll open up another issue about this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mezzarobba could you check that this resolves #2073?