Sanity checking FLINT

.github/workflows/CI.yml

@@ -93,18 +93,15 @@ jobs:
 
 
   ##############################################################################
-  # gcc build check no regressions
+  # gcc sanity check
   ##############################################################################
-  gcc-build-regression-check:
-    name: GCC build regression check (no tests)
+  gcc-sanity-check:
+    name: GCC sanity check
 
     runs-on: ubuntu-24.04
 
     env:
       CC: "gcc"
-      CFLAGS: "-march=native -std=c11 -Wall -Wextra -Werror"
-      MODULES: "build/thread_pool_merged.lo build/thread_support_merged.lo build/ulong_extras_merged.lo build/long_extras_merged.lo build/perm_merged.lo build/double_extras_merged.lo build/d_vec_merged.lo build/d_mat_merged.lo build/mpn_extras_merged.lo build/mpfr_vec_merged.lo build/mpfr_mat_merged.lo build/nmod_merged.lo build/nmod_vec_merged.lo build/nmod_mat_merged.lo build/nmod_poly_merged.lo build/mpn_mod_merged.lo build/fmpz_merged.lo build/fmpz_vec_merged.lo build/fmpz_mat_merged.lo build/fmpz_poly_merged.lo build/fmpz_mod_merged.lo build/fmpz_mod_vec_merged.lo build/fmpz_mod_mat_merged.lo build/fmpz_mod_poly_merged.lo build/fmpq_merged.lo build/fmpq_vec_merged.lo build/fmpq_mat_merged.lo build/fmpq_poly_merged.lo build/fq_merged.lo build/fq_vec_merged.lo build/fq_mat_merged.lo build/fq_poly_merged.lo build/fq_nmod_merged.lo build/fq_nmod_vec_merged.lo build/fq_nmod_mat_merged.lo build/fq_nmod_poly_merged.lo build/fq_zech_merged.lo build/fq_zech_mat_merged.lo build/fq_zech_poly_merged.lo build/fq_default_merged.lo build/fq_default_mat_merged.lo build/fq_default_poly_merged.lo build/fq_embed_merged.lo build/fq_nmod_embed_merged.lo build/fq_zech_embed_merged.lo build/padic_merged.lo build/padic_mat_merged.lo build/padic_poly_merged.lo build/qadic_merged.lo build/nmod_poly_factor_merged.lo build/fmpz_factor_merged.lo build/fmpz_poly_factor_merged.lo build/fmpz_mod_poly_factor_merged.lo build/fq_poly_factor_merged.lo build/fq_nmod_poly_factor_merged.lo build/fq_zech_poly_factor_merged.lo build/fq_default_poly_factor_merged.lo build/nmod_poly_mat_merged.lo build/fmpz_poly_mat_merged.lo build/mpoly_merged.lo build/nmod_mpoly_merged.lo build/fmpz_mpoly_merged.lo build/fmpz_mod_mpoly_merged.lo build/fmpq_mpoly_merged.lo build/fq_nmod_mpoly_merged.lo build/fq_zech_mpoly_merged.lo build/nmod_mpoly_factor_merged.lo build/fmpz_mpoly_factor_merged.lo build/fmpz_mod_mpoly_factor_merged.lo build/fmpq_mpoly_factor_merged.lo build/fq_nmod_mpoly_factor_merged.lo build/fq_zech_mpoly_factor_merged.lo build/fft_merged.lo build/fft_small_merged.lo"
-      # Everything until fmpz_poly_q
 
     steps:
       - uses: actions/checkout@v4
@@ -123,12 +120,15 @@ jobs:
           ./bootstrap.sh
           ./configure \
             CC=${CC} \
-            CFLAGS="${CFLAGS}" \
-            --disable-debug
+            --enable-sanity-check
 
-      - name: "Check regression in a subset of modules"
+      - name: "Build with sanity"
         run: |
-          $MAKE $MODULES
+          $MAKE
+
+      - name: "Build tests with sanity"
+        run: |
+          $MAKE
 
 
 

Makefile.in

@@ -80,6 +80,7 @@ GC_LIB_PATH:=@GC_LIB_PATH@
 NTL_LIB_PATH:=@NTL_LIB_PATH@
 
 CFLAGS:=@CFLAGS@
+CFLAGS_INLINE:=$(filter-out -Wmissing-declarations -Wmissing-prototypes,$(CFLAGS))
 TESTCFLAGS:=@TESTCFLAGS@
 CPPFLAGS:=-I$(ABS_SRC_DIR) -I$(SRC_DIR) @CPPFLAGS@ -DBUILDING_FLINT
 CPPFLAGS2:=-L$(ABS_FLINT_DIR) $(CPPFLAGS)
@@ -592,6 +593,10 @@ define xxx_OBJS_rule
 $(BUILD_DIR)/$(1)/%.o: $(ABS_SRC_DIR)/$(1)/%.c | $(BUILD_DIR)/$(1)
 	@echo "  CC  $$(<:$(ABS_SRC_DIR)/%=%)"
 	@$(CC) $(CFLAGS) $($(1)_CFLAGS) $(CPPFLAGS) $(LIB_CPPFLAGS) -c $$< -o $$@ $$(DEPFLAGS)
+
+$(BUILD_DIR)/$(1)/inlines.o: $(ABS_SRC_DIR)/$(1)/inlines.c | $(BUILD_DIR)/$(1)
+	@echo "  CC  $$(<:$(ABS_SRC_DIR)/%=%)"
+	@$(CC) $(CFLAGS_INLINE) $($(1)_CFLAGS) $(CPPFLAGS) $(LIB_CPPFLAGS) -c $$< -o $$@ $$(DEPFLAGS)
 endef
 
 ifeq ($(IS_OUT_OF_TREE),1)
@@ -618,6 +623,10 @@ define xxx_LOBJS_rule
 $(BUILD_DIR)/$(1)/%.lo: $(ABS_SRC_DIR)/$(1)/%.c | $(BUILD_DIR)/$(1)
 	@echo "  CC  $$(<:$(ABS_SRC_DIR)/%=%)"
 	@$(CC) $(PIC_FLAG) $(CFLAGS) $($(1)_CFLAGS) $(CPPFLAGS) $(LIB_CPPFLAGS) -c $$< -o $$@ $$(DEPFLAGS)
+
+$(BUILD_DIR)/$(1)/inlines.lo: $(ABS_SRC_DIR)/$(1)/inlines.c | $(BUILD_DIR)/$(1)
+	@echo "  CC  $$(<:$(ABS_SRC_DIR)/%=%)"
+	@$(CC) $(PIC_FLAG) $(CFLAGS_INLINE) $($(1)_CFLAGS) $(CPPFLAGS) $(LIB_CPPFLAGS) -c $$< -o $$@ $$(DEPFLAGS)
 endef
 
 ifeq ($(IS_OUT_OF_TREE),1)

configure.ac

@@ -231,6 +231,32 @@ yes|no)
 esac],
 enable_coverage="no")
 
+# NOTE: Maintainer-level only. Does not optimize, and turns on a lot of
+# warnings, all of which are turned to errors. Defaults debugging to no.
+AC_ARG_ENABLE(sanity-check,[],
+[case $enableval in
+yes|no)
+    ;;
+*)
+    AC_MSG_ERROR([Bad value $enableval for --enable-sanity-check. Need yes or no.])
+    ;;
+esac
+if test "$enableval" = "yes" && test "$cflags_set" = "yes";
+then
+    AC_MSG_ERROR([Cannot enable sanity check and push other CFLAGS at the same time.])
+elif test "$enableval" = "yes" && test "$testcflags_set" = "yes";
+then
+    AC_MSG_ERROR([Cannot enable sanity check and push other TESTCFLAGS at the same time.])
+fi],
+enable_sanity_check="no")
+
+# NOTE: -Wdeclaration-after-statement and -Wcast-qual is not in here. We also
+# remove -Wcast-function-type for GR.
+sanity_check_CFLAGS="-Werror -Wall -Wextra -Wno-cast-function-type -Wcast-align -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wredundant-decls -Wshadow -pedantic -std=c11 -O0"
+
+# We take CFLAGS but ignore -Wsign-compare, -Wmissing-declarations and -Wmissing-prototypes.
+sanity_check_TESTCFLAGS="-Werror -Wall -Wextra -Wno-cast-function-type -Wno-sign-compare -Wcast-align -Wnested-externs -Wpointer-arith -Wredundant-decls -Wshadow -pedantic -std=c11 -O0"
+
 AC_ARG_ENABLE(debug,
 [AS_HELP_STRING([--enable-debug],[Compile FLINT with debug information [default=yes]])],
 [case $enableval in
@@ -244,7 +270,12 @@ yes|no)
     AC_MSG_ERROR([Bad value $enableval for --enable-debug. Need yes or no.])
     ;;
 esac],
-enable_debug="yes")
+if test "$enable_sanity_check" = "no";
+then
+    enable_debug="yes"
+else
+    enable_debug="no"
+fi)
 
 AC_ARG_ENABLE(dependency-tracking,
 [AS_HELP_STRING([--enable-dependency-tracking],[Enable GCC automated dependency tracking [default=yes]])],
@@ -323,18 +354,6 @@ yes|no)
 esac],
 enable_mpfr_check="yes")
 
-# NOTE: Maintainer level only. Avoids any sort of optimization to speed up
-# builds.
-AC_ARG_ENABLE(fast-build,[],
-[case $enableval in
-yes|no)
-    ;;
-*)
-    AC_MSG_ERROR([Bad value $enableval for --enable-fast-build. Need yes or no.])
-    ;;
-esac],
-enable_fast_build="no")
-
 ################################################################################
 # packages
 ################################################################################
@@ -534,11 +553,7 @@ fi
 # architecture specifics
 ################################################################################
 
-if test "$enable_fast_build" = "no";
-then
-    gcc_cflags="-O3 "
-fi
-gcc_cflags="$gcc_cflags-pedantic -std=c11"
+gcc_cflags="-O3 -pedantic -std=c11"
 gcc_warnings="-Werror=implicit-function-declaration -Wall -Wno-stringop-overread -Wno-stringop-overflow -Wno-maybe-uninitialized"
 
 dnl We only try to provide specifics for those systems that currently supports
@@ -1240,7 +1255,31 @@ then
     [AC_MSG_ERROR([$CC does not support the flag -mavx512f needed for AVX512 instructions])])
 fi
 
-if test "$cflags_set" = "no";
+if test "$enable_sanity_check" = "yes";
+then
+    for flag in $sanity_check_CFLAGS;
+    do
+        AX_CHECK_COMPILE_FLAG([$flag],[save_CFLAGS="$flag $save_CFLAGS"],
+            [AC_MSG_ERROR([$CC does not support $flag needed for sanity check.])])
+    done
+    found_single="no"
+    for flag in $gcc_cflags_arch;
+    do
+        if test "$found_single" = "yes";
+        then
+            found_single="no"
+            break
+        else
+            AX_CHECK_COMPILE_FLAG([$flag],
+                                  [save_CFLAGS="$flag $save_CFLAGS"
+                                   sanity_check_TESTCFLAGS="$flag $sanity_check_TESTCFLAGS"
+                                   found_single="yes"],
+                                  [unset flint_cv_have_fft_small_x86_i
+                                   unset flint_cv_have_fft_small_arm_i])
+        fi
+    done
+    CFLAGS="$save_CFLAGS"
+elif test "$cflags_set" = "no";
 then
     for flag in $gcc_cflags $gcc_warnings;
     do
@@ -1272,10 +1311,8 @@ then
             fi
         done
     done
-    if test "$enable_fast_build" = no;
-    then
-        AX_CHECK_COMPILE_FLAG([-funroll-loops],[unroll_loops="yes"])
-    fi
+
+    AX_CHECK_COMPILE_FLAG([-funroll-loops],[unroll_loops="yes"])
     if test "$unroll_loops" = "yes";
     then
         AC_SUBST(UNROLL_LOOPS,1)
@@ -1292,7 +1329,12 @@ fi
 
 if test "$testcflags_set" = "no";
 then
-    TESTCFLAGS="$CFLAGS"
+    if test "$enable_sanity_check" = "no";
+    then
+        TESTCFLAGS="$CFLAGS"
+    else
+        TESTCFLAGS="$sanity_check_TESTCFLAGS"
+    fi
 else
     TESTCFLAGS="$TESTCFLAGS $save_CFLAGS"
 fi

src/acb-impl.h

@@ -0,0 +1,29 @@
+/*
+    Copyright (C) 2024 Albin Ahlbäck
+
+    This file is part of FLINT.
+
+    FLINT is free software: you can redistribute it and/or modify it under
+    the terms of the GNU Lesser General Public License (LGPL) as published
+    by the Free Software Foundation; either version 3 of the License, or
+    (at your option) any later version.  See <https://www.gnu.org/licenses/>.
+*/
+
+#ifndef ACB_IMPL_H
+#define ACB_IMPL_H
+
+#include "acb_types.h"
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+void acb_zeta_si(acb_t z, slong s, slong prec);
+
+void acb_gamma_stirling_eval(acb_t s, const acb_t z, slong nterms, int digamma, slong prec);
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* ACB_IMPL_H */

src/acb/agm.c

@@ -9,10 +9,9 @@
     (at your option) any later version.  See <https://www.gnu.org/licenses/>.
 */
 
+#include "arb-impl.h"
 #include "acb.h"
 
-void mag_agm(mag_t res, const mag_t x, const mag_t y);
-
 static void
 agm_helper(acb_t res, const acb_t a, const acb_t b, slong prec)
 {

src/acb/agm1.c

@@ -9,11 +9,10 @@
     (at your option) any later version.  See <https://www.gnu.org/licenses/>.
 */
 
+#include "arb-impl.h"
 #include "acb.h"
 #include "acb_poly.h"
 
-void mag_agm(mag_t res, const mag_t x, const mag_t y);
-
 /* Checks that |arg(z)| <= 3 pi / 4 */
 static int
 acb_check_arg(const acb_t z)
@@ -99,7 +98,7 @@ acb_agm_close_taylor(acb_t res, acb_t z, acb_t z2,
 }
 
 static void
-acb_agm1_around_zero(acb_t res, const acb_t z, slong prec)
+acb_agm1_around_zero(acb_t res, const acb_t z, slong FLINT_UNUSED(prec))
 {
     mag_t a, b;
     mag_init(a);
@@ -113,7 +112,7 @@ acb_agm1_around_zero(acb_t res, const acb_t z, slong prec)
     mag_clear(b);
 }
 
-void
+static void
 acb_agm1_basecase(acb_t res, const acb_t z, slong prec)
 {
     acb_t a, b, t, u;
@@ -207,7 +206,7 @@ acb_agm1_basecase(acb_t res, const acb_t z, slong prec)
     Computes (M(z), M'(z)) using a finite difference.
     Assumes z exact, |arg(z)| <= 3 pi / 4.
 */
-void
+static void
 acb_agm1_deriv_diff(acb_t Mz, acb_t Mzp, const acb_t z, slong prec)
 {
     mag_t err, t, C;
@@ -341,7 +340,7 @@ This is assuming that the circle at z with radius |eps| + r
 does not cross the negative half axis, which we check.
 */
 
-void
+static void
 acb_agm1_deriv_right(acb_t Mz, acb_t Mzp, const acb_t z, slong prec)
 {
     if (acb_is_exact(z))
@@ -496,7 +495,7 @@ acb_agm1(acb_t res, const acb_t z, slong prec)
     }
 }
 
-void
+static void
 acb_agm1_deriv(acb_t Mz, acb_t Mzp, const acb_t z, slong prec)
 {
     /*

src/acb/approx_dot.c

@@ -9,22 +9,12 @@
     (at your option) any later version.  See <https://www.gnu.org/licenses/>.
 */
 
-#include "acb.h"
-#include "mpn_extras.h"
-
 /* We need uint64_t instead of ulong on 32-bit systems for
    safe summation of 30-bit error bounds. */
 #include <stdint.h>
-
-void
-_arb_dot_addmul_generic(nn_ptr sum, nn_ptr serr, nn_ptr tmp, slong sn,
-    nn_srcptr xptr, slong xn, nn_srcptr yptr, slong yn,
-    int negative, flint_bitcnt_t shift);
-
-void
-_arb_dot_add_generic(nn_ptr sum, nn_ptr serr, nn_ptr tmp, slong sn,
-    nn_srcptr xptr, slong xn,
-    int negative, flint_bitcnt_t shift);
+#include "mpn_extras.h"
+#include "arb-impl.h"
+#include "acb.h"
 
 static void
 _arb_dot_output(arb_t res, nn_ptr sum, slong sn, int negative,
@@ -84,7 +74,7 @@ _arb_dot_output(arb_t res, nn_ptr sum, slong sn, int negative,
         xn = ARF_SIZE(xm); \
         xnegative = ARF_SGNBIT(xm); \
         shift = s_sum_exp - xexp; \
-        if (shift >= s_sn * FLINT_BITS) \
+        if (shift >= (ulong) s_sn * FLINT_BITS) \
         { \
         } \
         else \
@@ -173,7 +163,7 @@ _arf_complex_mul_gauss(arf_t e, arf_t f, const arf_t a, const arf_t b,
 FLINT_DLL extern slong acb_dot_gauss_dot_cutoff;
 #define GAUSS_CUTOFF acb_dot_gauss_dot_cutoff
 
-void
+static void
 acb_approx_dot_simple(acb_t res, const acb_t initial, int subtract,
     acb_srcptr x, slong xstep, acb_srcptr y, slong ystep, slong len, slong prec)
 {
@@ -584,7 +574,7 @@ acb_approx_dot(acb_t res, const acb_t initial, int subtract, acb_srcptr x, slong
                     exp = xexp + yexp;
                     shift = sum_exp - exp;
 
-                    if (shift >= sn * FLINT_BITS)
+                    if (shift >= (ulong) sn * FLINT_BITS)
                     {
                     }
                     else if (xn <= 2 && yn <= 2 && sn <= 3)

src/acb/atan.c

@@ -12,7 +12,7 @@
 #include "acb.h"
 
 /* branch cuts are on (+/-i)*[1,inf] */
-int
+static int
 acb_atan_on_branch_cut(const acb_t z)
 {
     arb_t unit;