Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name conflicts with small macro from rpcndr #2100

Merged
merged 2 commits into from
Oct 27, 2024

Conversation

tobiasdiez
Copy link
Contributor

On Windows, if you include windows.h then you get the following error

C:/Users/Tobia/.conda/envs/sage-dev/Library/include\flint/qsieve.h(66): error C2059: syntax error: 'type'
C:/Users/Tobia/.conda/envs/sage-dev/Library/include\flint/qsieve.h(69): error C2059: syntax error: '}'

since small is defined as a macro (see eg https://stackoverflow.com/questions/27793470/why-does-small-give-an-error-about-char). To fix this, small is undefined before its used as a variable name.

src/qsieve.h Outdated Show resolved Hide resolved
@albinahlback
Copy link
Collaborator

Good catch!

Co-authored-by: Albin Ahlbäck <[email protected]>
@albinahlback albinahlback merged commit 8ed328a into flintlib:main Oct 27, 2024
@albinahlback
Copy link
Collaborator

Thanks!

@tobiasdiez tobiasdiez deleted the patch-1 branch October 28, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants