Fix crash in fmpz_poly_sub_fmpz #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `poly` is a zero polynomial and `c` the value zero then the `fmpz_neg` can crash (it definitely does in Nemo). Discovered via extended ring conformance tests in Nemo.
|
Thanks. Indeed, if we have a zero polynomial we should never dereference We should probably get this tested as well, though, but perhaps on a broader level (macros etc.). I'll add an issue about this. In the meantime, let's have this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
polyis a zero polynomial andcthe value zero thenthe
fmpz_negcan crash (it definitely does in Nemo).Discovered via extended ring conformance tests in Nemo. See also Nemocas/Nemo.jl#1930