Skip to content

[ruby34] Fix frozen string warning #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tjallingvanderwal
Copy link

@tjallingvanderwal tjallingvanderwal commented Mar 31, 2025

This change fixes the warning below, that appears when running Ruby 3.4.

.../flipper/lib/flipper/instrumentation/log_subscriber.rb:60:
warning: literal string will be frozen in the future
(run with --debug-frozen-string-literal for more information)

```
.../flipper/lib/flipper/instrumentation/log_subscriber.rb:60:
warning: literal string will be frozen in the future
(run with --debug-frozen-string-literal for more information)
```
@tjallingvanderwal
Copy link
Author

FYI I've tried to run the test suite locally, but did not succeed to get it running (and have limited time to try). So relying on the CI here.

$ docker-compose run --rm app bundle install

...


Bundler found conflicting requirements for the Ruby version:
  In Gemfile:
    Ruby

    flipper was resolved to 1.3.4, which depends on
      Ruby (>= 2.6)

    rails (~> 8.0) was resolved to 8.0.2, which depends on
      Ruby (>= 3.2.0)

@tjallingvanderwal tjallingvanderwal marked this pull request as ready for review March 31, 2025 08:42
@jnunemaker
Copy link
Collaborator

Fixed this over in #922 I think. Thanks for alerting!

@jnunemaker jnunemaker closed this Mar 31, 2025
@tjallingvanderwal tjallingvanderwal deleted the fix_frozen_string_warnings branch April 1, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants