Skip to content

Flipper Cigarette v0.1.2 #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

fuckmaz
Copy link

@fuckmaz fuckmaz commented Jan 31, 2025

Application Submission

  • simple cigarette app for flipper zero

Extra Requirements

  • none

Author Checklist (Fill this out)

  • [ x] I've read the contribution guidelines and my PR follows them
  • [ x] I own the code I'm submitting or have code owner's permission to submit it
  • [ x] I have validated the manifest file(s) with python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zip

Reviewer Checklist (Don't fill this out)

  • Bundle is valid
  • There are no obvious issues with the source code
  • I've ran this application and verified its functionality

@doomwastaken doomwastaken self-assigned this Jan 31, 2025
@doomwastaken doomwastaken added app (new) QA pending To be reviewed by QA fixes needed Unresolved issues with the app requiring maintainer's attention and removed QA pending To be reviewed by QA labels Jan 31, 2025
@fuckmaz
Copy link
Author

fuckmaz commented Feb 5, 2025

what fixes are needed? the app works and i completed all the checks

@jaylikesbunda
Copy link
Contributor

what fixes are needed? the app works and i completed all the checks

you can check here: https://github.com/flipperdevices/flipper-application-catalog/actions/runs/13073339095/job/36567540777
seems to be icon header include

@fuckmaz fuckmaz changed the title Flipper Cigarette v0.1.1 Flipper Cigarette v0.1.2 Feb 11, 2025
@fuckmaz
Copy link
Author

fuckmaz commented Feb 11, 2025

fixed the issue and bumped to v0.1.2 including new features

@doomwastaken
Copy link
Member

Error: 10:43:08.252 [E] App ID 'cigarette' in manifest does not match app ID 'flipper_cigarette' from path '/home/runner/work/flipper-application-catalog/flipper-application-catalog/applications/Games/flipper_cigarette/manifest.yml'

seems like you forgot to change app name in second spot

@fuckmaz
Copy link
Author

fuckmaz commented Feb 13, 2025

no way i missed that.. i renamed it :)

@doomwastaken
Copy link
Member

Don't worry, takes me like no time to retry :) Will accept it once I'm done. Sorry for previous delay, been on a sick leave, usually we try to review within 48 hours on workdays

@doomwastaken
Copy link
Member

Also we have limitations to markdown, you can find it in docs. It is heavily limited for sake of properly rendering those changes on mobile devices

@fuckmaz
Copy link
Author

fuckmaz commented Feb 19, 2025

alright - i'll get the description etc. ready today finally!

@doomwastaken
Copy link
Member

12:34:07.084 [I] Including description from file /tmp/tmp57msctx7/code/README.md Error: 12:34:07.110 [E] Markdown error: Markdown element 'Html' is not allowed

Seems like you still have markdown elements that are not supported in README.md, what a lot of people do, regarding our catalog is keep 2 separate readme files, one for submission and one for the git repository itself, if it has some extra information, you can check other apps that were approved for examples

@fuckmaz
Copy link
Author

fuckmaz commented Feb 28, 2025

i know - didn't get to fix it but today is the day finally!

using a seperate readme file for this makes sense, will do it like that!

thanks!

@fuckmaz
Copy link
Author

fuckmaz commented Mar 4, 2025

should be to spec now :)

@doomwastaken
Copy link
Member

So close! You forgot to update commit hash, so it is linking it to 2 commits ago!

@fuckmaz
Copy link
Author

fuckmaz commented Mar 4, 2025

changed the hash to current commit :))

@doomwastaken
Copy link
Member

https://github.com/flipperdevices/flipper-application-catalog/pull/615/files
leads to 2 paths:
changelog: "@./CHANGELOG.md"
description: "@./DESCRIPTION.md"

Description looks fine for me, probably the
tags that are triggering it at https://raw.githubusercontent.com/fuckmaz/flipper_cigarette/refs/heads/dev/CHANGELOG.md

@doomwastaken
Copy link
Member

We should actually include the line that triggers the error, will write it down

@fuckmaz
Copy link
Author

fuckmaz commented Mar 4, 2025

i removed all html linebreaks for now

@doomwastaken
Copy link
Member

Give me a few minutes to run it locally

@doomwastaken
Copy link
Member

Okay I got good and bad news lol, good news we fixed other files, bad things, we need to improve logging a bit, when I run the script from above
python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zip

basically I figured it was stumbling on
21:19:08.585 [I] Including description from file C:\Users\user\AppData\Local\Temp\tmpf1zo7onk\code\DESCRIPTION.md <Element 'div' at 0x00000163FFEE4180> [' - multiple Cigarettes\n - cancer progress-bar\n - realistic smoke- and cough-effects', 'special thanks goes out to [jaylikesbunda](https://github.com/jaylikesbunda)!', 'xoxo - maz <3', ''] 21:19:08.608 [E] Markdown error: Markdown element 'Code Block' is not allowed: <markdown.blockprocessors.CodeBlockProcessor object at 0x00000163FFEEF690>

which means it is parsing the readme, so my suggested fix is from few messages back, make a READMESHORT.md or smth, and put only basic description with no html/expanded markdown elements and it should work.

Atleast I disabled the markdown check locally and build completes

@doomwastaken doomwastaken marked this pull request as draft June 10, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (new) fixes needed Unresolved issues with the app requiring maintainer's attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants