-
Notifications
You must be signed in to change notification settings - Fork 268
Flipper Cigarette v0.1.2 #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Flipper Cigarette v0.1.2 #615
Conversation
what fixes are needed? the app works and i completed all the checks |
you can check here: https://github.com/flipperdevices/flipper-application-catalog/actions/runs/13073339095/job/36567540777 |
fixed the issue and bumped to v0.1.2 including new features |
Error: 10:43:08.252 [E] App ID 'cigarette' in manifest does not match app ID 'flipper_cigarette' from path '/home/runner/work/flipper-application-catalog/flipper-application-catalog/applications/Games/flipper_cigarette/manifest.yml' seems like you forgot to change app name in second spot |
no way i missed that.. i renamed it :) |
Don't worry, takes me like no time to retry :) Will accept it once I'm done. Sorry for previous delay, been on a sick leave, usually we try to review within 48 hours on workdays |
Also we have limitations to markdown, you can find it in docs. It is heavily limited for sake of properly rendering those changes on mobile devices |
alright - i'll get the description etc. ready today finally! |
Seems like you still have markdown elements that are not supported in README.md, what a lot of people do, regarding our catalog is keep 2 separate readme files, one for submission and one for the git repository itself, if it has some extra information, you can check other apps that were approved for examples |
i know - didn't get to fix it but today is the day finally! using a seperate readme file for this makes sense, will do it like that! thanks! |
should be to spec now :) |
So close! You forgot to update commit hash, so it is linking it to 2 commits ago! |
changed the hash to current commit :)) |
https://github.com/flipperdevices/flipper-application-catalog/pull/615/files Description looks fine for me, probably the |
We should actually include the line that triggers the error, will write it down |
i removed all html linebreaks for now |
Give me a few minutes to run it locally |
Okay I got good and bad news lol, good news we fixed other files, bad things, we need to improve logging a bit, when I run the script from above basically I figured it was stumbling on which means it is parsing the readme, so my suggested fix is from few messages back, make a READMESHORT.md or smth, and put only basic description with no html/expanded markdown elements and it should work. Atleast I disabled the markdown check locally and build completes |
Application Submission
Extra Requirements
Author Checklist (Fill this out)
python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zip
Reviewer Checklist (Don't fill this out)