Morse Master and Moon Phases

[w84death]

Application Submission

The Morse Master is an interactive application for Flipper Zero that helps you learn and practice Morse code. The app offers two main modes: a Learning Mode to familiarize yourself with Morse code patterns and a Practice Mode to test your skills.

Author Checklist (Fill this out)

• I've read the contribution guidelines and my PR follows them
• I own the code I'm submitting or have code owner's permission to submit it
• I have validated the manifest file(s) with python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zip

Reviewer Checklist (Don't fill this out)

• Bundle is valid
• There are no obvious issues with the source code
• I've ran this application and verified its functionality

[w84death]

I hope I did made this correctly. As the Moon Phases app PR was having some problems, here is the second application.

Morse Master is way more useful, feature rich and actually helpful. I would like to have this one in the catalog over the last simple one. Worse case scenario I can discard everything and do new fork and add just Morse Master to the catalog.

As good I am with git, the public PR's are new to me. I got a little bit confused with having two on the same codebase (and two branches).

[doomwastaken]

Nvm previous comment, I was being silly, let me try in my own PR

[w84death]

OK. Too bad I did not see the previous one ;)

[doomwastaken]

Actually you can just update this PR alone, no need to update previous one. I will close it. Update both manifest.yaml -> manifest.yml and bump commit hash in both repos. Thank you for your patience

[doomwastaken]

Fixed extensions myself, next fix is on the side of your repo.
https://github.com/w84death/moon-phases/blob/main/application.fam (and second app too)
appid="p1x_moon_phases",
must match one that is in the PR
Error: 09:08:11.720 [E] App ID 'p1x_morse_master' in manifest does not match app ID 'morse_master' from path '/home/runner/work/flipper-application-catalog/flipper-application-catalog/applications/Media/morse_master/manifest.yml'

[doomwastaken]

Header is missing in the build
Error: /tmp/tmpw56t_31c/code/p1x_moon_phases.c:15:10: fatal error: p1x_moon_phases_icons.h: No such file or directory

same for other app

All of this can be validated here via this part

I have validated the manifest file(s) with python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zip

[w84death]

That is strange as I got those files before. I'm doing those new pushes from other computer. I will check the old one and restore them or create new one. It's not in gitignore so they should be in the repo. But this explains one bug report that icons was missing.

EDIT: this file is created automatically but not saved. I will re-read the manual and make it.