Skip to content

Add Nearby Files #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add Nearby Files #805

wants to merge 10 commits into from

Conversation

Stichoza
Copy link

Application Submission

  • A GPS-enabled file browser that displays files sorted by distance from your current location.

Extra Requirements

  • GPS module is required.

Author Checklist (Fill this out)

  • I've read the contribution guidelines and my PR follows them
  • I own the code I'm submitting or have code owner's permission to submit it
  • I have validated the manifest file(s) with python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zip

Reviewer Checklist (Don't fill this out)

  • Bundle is valid
  • There are no obvious issues with the source code
  • I've ran this application and verified its functionality

@doomwastaken doomwastaken self-assigned this Jul 22, 2025
@doomwastaken doomwastaken added app (new) QA pending To be reviewed by QA labels Jul 22, 2025
@Stichoza
Copy link
Author

Stichoza commented Jul 25, 2025

I saw that it is the submodule pull that caused the build error.

Cloning into '/tmp/tmpdw53wzv3'...
Submodule 'lib/minmea' ([email protected]:kosma/minmea.git) registered for path 'lib/minmea'
Cloning into '/tmp/tmpdw53wzv3/lib/minmea'...
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Is there anything that I should change on my side? The build (GitHub Action) works fine in my repository, clones submodules with no problem.

Same part from my build:

Submodule 'lib/minmea' ([email protected]:kosma/minmea.git) registered for path 'lib/minmea'
  Cloning into '/home/runner/work/flipper-nearby-files/flipper-nearby-files/lib/minmea'...
  Submodule path 'lib/minmea': checked out 'b2c60df3c3261843e1787190402f11a686d4273e'

@doomwastaken
Copy link
Member

I will retry the workflow and try it locally. However most will be done after weekend (if re-run wont work)

@Stichoza
Copy link
Author

Apologies for too much commits, I just cannot test it locally. The python script crashes with TypeError: unsupported operand type(s) for |: '_CallableType' and 'NoneType'. Tried on macOS and Ubuntu, no luck.

I hope this last commit fixes the markdown validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (new) QA pending To be reviewed by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants