Skip to content

[FL-3925] JS views finished #4155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: dev
Choose a base branch
from
Open

[FL-3925] JS views finished #4155

wants to merge 27 commits into from
+1,498 −50

Conversation

portasynthinca3
Copy link
Member

@portasynthinca3 portasynthinca3 commented Mar 24, 2025 •
edited
Loading

What's new

  • Finished adding adapter modules for all the GUI views: button_menu, button_panel, menu, number_input, popup, variable_item_list (as vi_list)

Verification

  • Run the gui.js example script, verify that it works as expected

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@portasynthinca3
js: value destructuring and tests
20294a8
@portasynthinca3
js: temporary fix to see size impact
f51d726
@portasynthinca3
js_val: reduce code size 1
ca0fc5f
@portasynthinca3
i may be stupid.
74700ce
@portasynthinca3
test: js_value args
cca650e
@portasynthinca3
Revert "js: temporary fix to see size impact"
11b82c0 
This reverts commit f51d726.
@portasynthinca3
pvs: silence warnings
4a69443
@portasynthinca3
style: formatting
35d500d
@portasynthinca3
pvs: silence warnings?
4d9d1c6
@portasynthinca3
pvs: silence warnings??
1c3f2e3
@portasynthinca3
js_value: redesign declaration types for less code
e59eed4
@portasynthinca3
js: temporary fix to see size impact
d6a46f0
@portasynthinca3
style: formatting
541ea2a
@portasynthinca3
pvs: fix helpful warnings
245800e
@portasynthinca3
js_value: reduce .rodata size
e1f7a78
@portasynthinca3
pvs: fix helpful warning
7a9b0a9
@portasynthinca3
js_value: reduce code size 1
bccc4f4
@portasynthinca3
fix build error
6b6ea5d
@portasynthinca3
style: format
b5a1f95
@portasynthinca3
Revert "js: temporary fix to see size impact"
eb075f7 
This reverts commit d6a46f0.
@portasynthinca3
style: format
544193e
@portasynthinca3
js: move to new arg parser
49e5649
@portasynthinca3
style: format
db899d4
@portasynthinca3
feat: all js views done
f7f6856
@portasynthinca3 portasynthinca3 added New Feature Contains an IMPLEMENTATION of a new feature JS JS Runtime, loader and API labels Mar 24, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 24, 2025 •
edited
Loading

Compiled f7 firmware for commit 93106609:

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 24, 2025 •
edited
Loading

PVS-Studio report for commit a78f92e1:

@portasynthinca3 portasynthinca3 marked this pull request as ready for review April 29, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
JS JS Runtime, loader and API New Feature Contains an IMPLEMENTATION of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@portasynthinca3