Skip to content

CLI: Fix crash with unexpected plugin files #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

WillyJL
Copy link
Contributor

@WillyJL WillyJL commented Jun 29, 2025

What's new

  • simply ignores unexpected files in CLI plugins dir instead of crashing
  • this is because some CFWs had their own CLI plugin system before with a different naming scheme, and some of those leftover plugin files caused people moving from CFW to OFW to crash when connecting to qFlipper / lab.flipper.net (sorry about that 😅)

Verification

  • put any file in /ext/apps_data/cli/plugins/ that does not start with cli_ or does not end with .fal
  • flipper should ignore it when plugging into qFlipper / lab.flipper.net instead of crashing

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants