WIP: Feature/add dlopen config flag #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitMensch
suggested changes
Jan 8, 2025
libcob/coblocal.h
Outdated
| @@ -372,6 +372,8 @@ typedef struct __cob_settings { | |||
| unsigned int cob_core_on_error; /* signal handling and possible raise of SIGABRT | |||
| / creation of coredumps on runtime errors */ | |||
| char *cob_core_filename; /* filename for coredump creation */ | |||
|
|
|||
| int cob_load_global; /* Wether dlopen should use the global or local namespace */ | |||
There was a problem hiding this comment.
that's a setting from call.c, so move up before name_convert and as it is a plain boolean change its type to unsigned int
|
This seems to be superseded by OCamlPro#209 - please apply the review-requested-changes (as it is the same branch the other will be updated as well), then close this one. |
|
Addressed the comments @GitMensch. Now closing this in favor of OCamlPro#209 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just to "show around", not be be merged. Will open an upstream PR for that.