-
Notifications
You must be signed in to change notification settings - Fork 1
feat: use vendoring step in Rust pure build #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
73b323f to
358876f
Compare
|
I pushed a change to use the It would have been nice if we could use the config generated by |
199c892 to
66fff01
Compare
|
|
||
| # This build vendors dependencies in a build with the sandbox off | ||
| # so that we can use the network to fetch dependencies. | ||
| [build.deps] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used prefixed names for the Go and Ruby projects that the intermediate packages and store paths have more recognisable names when switching between projects in this repo.
| [build.deps] | |
| [build.quotes-app-rs-deps] |
This adds an impure build to vendor dependencies that can later be used in the Rust pure build. Creating the vendored dependencies is easy, but using the dependencies in the build requires creating a config file for Cargo to read. Cargo reads _some_ environment variables at runtime, just not these variables in particular.
66fff01 to
a031f9c
Compare
dcarley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and passing tests. Do think we should rename the build before merging though.
|
renamed the deps build for consistency |
This adds an impure build to vendor dependencies that can later be used in the Rust pure build. Creating the vendored dependencies is easy, but using the dependencies in the build requires creating a config file for Cargo to read. Cargo reads some environment variables at runtime, just not these variables in particular.