Allow FLOXBIN to be a nix run command #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find this useful to test changes from tags and feature branches, e.g.
% FLOXBIN="nix run github:flox/flox/brantley/remove-layered-activation-from-manifest-build --" make
./test.sh
Using flox binary: nix run github:flox/flox/brantley/remove-layered-activation-from-manifest-build --
🔨 Building quotes-app-cpp with Flox...
The recent addition of quoting prevented this:
% FLOXBIN="nix run github:flox/flox/brantley/remove-layered-activation-from-manifest-build --" make
./test.sh
Using flox binary: nix run github:flox/flox/brantley/remove-layered-activation-from-manifest-build --
🔨 Building quotes-app-cpp with Flox...
./test.sh: line 30: nix run github:flox/flox/brantley/remove-layered-activation-from-manifest-build --: No such file or directory
make: *** [test] Error 127
Merged
ysndr
approved these changes
Jun 19, 2025
Contributor
ysndr
left a comment
ysndr
left a comment
There was a problem hiding this comment.
Do you want to leave a comment in test.sh that we deliberately removed the quoting?
I fear otherwise the next person will go and quote them again..
Contributor
Author
Good point. I'm now going to re-use this for #17 though, so we don't need to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find this useful to test changes from tags and feature branches, e.g.
The recent addition of quoting prevented this: