feat: Rework flox activation inside vscode extension #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team-developer-support
gilmishal
changed the title
gilmishal
reviewed
Nov 19, 2025
gilmishal
reviewed
Nov 19, 2025
gilmishal
reviewed
Nov 19, 2025
gilmishal
reviewed
Nov 19, 2025
gilmishal
reviewed
Nov 19, 2025
This was
linked to
issues
Nov 19, 2025
Closed
gilmishal
force-pushed
the
feat/support-remote-workspaces
branch
2 times, most recently
from
255d5c9 to
033ce64
Compare
gilmishal
force-pushed
the
feat/support-remote-workspaces
branch
from
e5c7fef to
50af0b0
Compare
gilmishal
approved these changes
Dec 12, 2025
Add ability to deactivate Flox environment without restarting VSCode. This includes a new deactivate button in the Flox info view and a corresponding command registration. Also includes minor formatting fixes (trailing newline cleanup).
Services status data is returned as a single JSON array, not as newline-separated JSON objects. This fix parses the entire response as a single JSON array rather than attempting to parse each line individually.
…ng VSCode Previously, flox.activate would restart VSCode in a flox context using env.reopen(). This commit changes the behavior to: - Run 'flox activate -- sleep infinity' as a background process - Capture and store the PID for later cleanup - Implement flox.deactivate command to kill the background process - Use spawn() instead of exec() to get immediate PID access - Process automatically dies when VSCode closes (detached: false) This approach works correctly in remote VSCode sessions since the extension code runs on the remote server.
garbas
force-pushed
the
feat/support-remote-workspaces
branch
from
f871dcb to
2cb0a4d
Compare
Contributor
Author
|
I've found a few minor issues, but I'll open issues and we can fix them later |
This was referenced Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to rework how we activate a flox environment within vscode inorder to support remote development (wsl2, dev contaioners, ssh)