Skip to content

docs(nvm.md): Update nvm migration guide per feedback #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

brendaneamon
Copy link
Member

@brendaneamon brendaneamon commented Dec 17, 2024

Notes for reviewers

  • Added a section on node-gyp, because this is definitely an area where Flox will shine in comparison with nvm (thanks, @stahnma)
  • Added an optional section about using a pkg-group, which I'm recommending in cases where the Node.js version to install is on the older side
  • Added some clarification about the nodejs package versus those that have numerical suffixes

@brendaneamon brendaneamon self-assigned this Dec 17, 2024
@floxbot floxbot added the documentation Improvements or additions to documentation label Dec 17, 2024
Copy link

@brendaneamon brendaneamon force-pushed the brendan/nvm-guide-edits branch 4 times, most recently from bd353ed to 28c6ae7 Compare December 17, 2024 16:24
Copy link

@brendaneamon brendaneamon force-pushed the brendan/nvm-guide-edits branch from 28c6ae7 to 39af0bc Compare December 17, 2024 17:04
Copy link

Copy link

@brendaneamon brendaneamon force-pushed the brendan/nvm-guide-edits branch from 4d157c8 to 5f1fb1b Compare December 17, 2024 19:12
Copy link

@brendaneamon brendaneamon force-pushed the brendan/nvm-guide-edits branch from 5f1fb1b to 16ac61f Compare December 17, 2024 19:13
@brendaneamon brendaneamon marked this pull request as ready for review December 17, 2024 19:14
Copy link

@brendaneamon brendaneamon force-pushed the brendan/nvm-guide-edits branch from 16ac61f to 427d007 Compare December 17, 2024 21:40
Copy link

@brendaneamon brendaneamon force-pushed the brendan/nvm-guide-edits branch from 427d007 to 1c0d7e5 Compare December 18, 2024 11:16
Copy link

@brendaneamon brendaneamon merged commit 44e6102 into preview Dec 18, 2024
3 checks passed
@brendaneamon brendaneamon deleted the brendan/nvm-guide-edits branch December 18, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants