Skip to content

Brendan/add link validation #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 17, 2024
Merged

Conversation

brendaneamon
Copy link
Member

This PR adds link validation to the build process.

@brendaneamon brendaneamon added the documentation Improvements or additions to documentation label Sep 10, 2024
@brendaneamon brendaneamon self-assigned this Sep 10, 2024
@bryanhonof bryanhonof force-pushed the brendan/add-link-validation branch from ecf8573 to a6d5f27 Compare September 11, 2024 16:06
@bryanhonof bryanhonof force-pushed the brendan/add-link-validation branch from a6d5f27 to 8d94163 Compare September 11, 2024 16:14
@bryanhonof bryanhonof enabled auto-merge (squash) September 11, 2024 16:14
Copy link
Member

@bryanhonof bryanhonof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably never work due to a plugin we use.

- awesome-pages:

The whole ... | flat | something is processed after the validation is done. So mkdocs will never pick up on the pages that come from that plugin.

Ref: lukasgeiter/mkdocs-awesome-nav#92 (comment)

Copy link

Copy link

Copy link

Copy link

@garbas garbas requested a review from bryanhonof September 17, 2024 16:39
@bryanhonof bryanhonof merged commit 97eabee into preview Sep 17, 2024
3 checks passed
@bryanhonof bryanhonof deleted the brendan/add-link-validation branch September 17, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants