Skip to content

Document how to use Gitlab #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Document how to use Gitlab #22

merged 4 commits into from
Sep 16, 2024

Conversation

garbas
Copy link
Contributor

@garbas garbas commented Sep 16, 2024

No description provided.

@floxbot floxbot added the documentation Improvements or additions to documentation label Sep 16, 2024
@garbas garbas requested a review from bryanhonof September 16, 2024 16:04
Copy link

@garbas
Copy link
Contributor Author

garbas commented Sep 16, 2024

An example of an successful Gitlab pipeline -> https://gitlab.com/flox-examples/floxdocs/-/jobs/7836482849

@garbas garbas requested review from tomberek and ghudgins September 16, 2024 16:25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking nit: there's a trailing (r on the flox/install-flox-action line


## GitLab

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be nice to have a small amount of explainer of what you're going to do in GitLab (even if it's just "similar to GitHub, we are going to setup ci.yaml")

Copy link
Contributor

@ghudgins ghudgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments were non-blocking. LGTM

Copy link

@garbas garbas enabled auto-merge (squash) September 16, 2024 22:17
Copy link

@garbas garbas merged commit 54c9c5b into preview Sep 16, 2024
3 checks passed
@garbas garbas deleted the gitlab branch September 16, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants