feat: rewrite customizing environments #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmitchell
force-pushed
the
push-yuzzmytxyxxq
branch
from
aea9589 to
b79b446
Compare
zmitchell
requested review from
rossturk,
jennymahmoudi,
brendaneamon and
barstoolbluz
barstoolbluz
approved these changes
Jun 9, 2025
zmitchell
force-pushed
the
push-yuzzmytxyxxq
branch
from
b79b446 to
d2e9bfb
Compare
jennymahmoudi
approved these changes
Jun 10, 2025
| ``` | ||
| The logic for deciding where a customization should go is application specific, but there are some simple guidelines you can follow. | ||
| For a full discussion of what logic to place in which section and why, see the [activation concept page][activation_concept]. | ||
| Otherwise, try this: |
There was a problem hiding this comment.
I like the idea of logic to explain this but I don't think the bulleted list format is working here. Perhaps it's just that the indentation didn't work as you intended?
There was a problem hiding this comment.
Oh that definitely got mangled
There was a problem hiding this comment.
So our linter yells at me if the indentation is 4 spaces, but it renders properly. It doesn't yell at you if you use 2 spaces, but then it doesn't render properly 🫠
There was a problem hiding this comment.
Fixed this by ignoring the linter. I also added a lint shell alias to the environment so you can check this kind of thing locally without needing to remember that the name of the command is actually markdownlint-cli2.
zmitchell
force-pushed
the
push-yuzzmytxyxxq
branch
from
d2e9bfb to
db6d1cf
Compare
This previously focused exclusively on shell hooks and used them to run a service. This now shows a user how to leverage the hook, profile, and vars sections to customize their shell environment in an activated environment.
zmitchell
force-pushed
the
push-yuzzmytxyxxq
branch
from
db6d1cf to
95d5af3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previously focused exclusively on shell hooks and used them to run a service. This now shows a user how to leverage the hook, profile, and vars sections to customize their shell environment in an activated environment.