feat: update build concept page #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Describe why you would choose one over the other and what the trade-offs are.
ysndr
reviewed
Jun 20, 2025
docs/concepts/manifest-builds.md
Outdated
| @@ -79,11 +79,13 @@ Builds can be performed with different levels of "purity", meaning different lev | |||
| This is controlled with the `sandbox` option. | |||
|
|
|||
| By default this option is set to `"off"`, which instructs the Flox CLI to perform the build in the root of the repository with no restrictions on network or filesystem access. | |||
| This allows your build to use local caches or intermediate build artifacts that already exist. | |||
| This is convenient because it allows your build scripts to work as they do in your development environment, such as using local caches and intermediate build artifacts that already exist. | |||
| However, there are less guarantees that the build is reproducible, meaning that both the build script and built package may not work the same way on another machine. | |||
There was a problem hiding this comment.
suggestion:
However, that also implies that builds can access files or programs specific to your machine, e.g. config files in
$HOME, applications installed system wide, etc. and potentially embed this information in the resulting binary.
This can subsequently hurt the reproducibility of build script and the ability run binaries on other machines where those referenced files do not exist.
There was a problem hiding this comment.
Thanks! I golfed it a tiny bit and added to a separate commit.
Wordsmithed with Yannik.
dcarley
approved these changes
Jun 20, 2025
zmitchell
pushed a commit
that referenced
this pull request
Jun 24, 2025
feat: update build concept page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second commit contains the actual content changes.
Closes #237