outputs: azure_logs_ingestion: Update time_generated description#2411
outputs: azure_logs_ingestion: Update time_generated description#2411hashtagchris wants to merge 1 commit intofluent:masterfrom
Conversation
📝 WalkthroughWalkthroughUpdated documentation for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pipeline/outputs/azure_logs_ingestion.md`:
- Line 35: Update the `time_generated` description to clarify the floating-point
representation: state that when disabled the timestamp is a floating‑point
number representing seconds since the Unix epoch (i.e., Unix time as fractional
seconds), and ensure the wording references `time_key` so it reads: "If
disabled, it is a floating-point number of seconds since the Unix epoch." This
aligns the `time_generated` explanation with other plugin docs (GELF, Plot) and
removes ambiguity about the reference point.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f739d277-ee95-4aa1-a860-810c159ec0b2
📒 Files selected for processing (1)
pipeline/outputs/azure_logs_ingestion.md
`time_generated` influences the time format, not the addition of the time field. https://github.com/fluent/fluent-bit/blob/a1d9c2a9a637bba1d8918c6c7a49b8279fd6df0a/plugins/out_azure_logs_ingestion/azure_logs_ingestion.c#L113-L131 Signed-off-by: Chris Sidi <hashtagchris@github.com>
The
time_generatedconfig setting influences the time format, not the addition of a timestamp field as previously documented.Reference: https://github.com/fluent/fluent-bit/blob/a1d9c2a9a637bba1d8918c6c7a49b8279fd6df0a/plugins/out_azure_logs_ingestion/azure_logs_ingestion.c#L107-L131
Summary by CodeRabbit