Skip to content

outputs: azure_logs_ingestion: Update time_generated description#2411

Open
hashtagchris wants to merge 1 commit intofluent:masterfrom
hashtagchris:patch-1
Open

outputs: azure_logs_ingestion: Update time_generated description#2411
hashtagchris wants to merge 1 commit intofluent:masterfrom
hashtagchris:patch-1

Conversation

@hashtagchris
Copy link

@hashtagchris hashtagchris commented Mar 11, 2026

The time_generated config setting influences the time format, not the addition of a timestamp field as previously documented.

Reference: https://github.com/fluent/fluent-bit/blob/a1d9c2a9a637bba1d8918c6c7a49b8279fd6df0a/plugins/out_azure_logs_ingestion/azure_logs_ingestion.c#L107-L131

Summary by CodeRabbit

  • Documentation
    • Clarified the time_generated parameter: when enabled, timestamps under the configured key are ISO 8601 strings; when disabled, timestamps are floating‑point seconds since the Unix epoch.
    • Updated examples and descriptions to make the formatting distinction explicit, improving clarity for configuration authors.

@hashtagchris hashtagchris requested review from a team and eschabell as code owners March 11, 2026 02:31
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2026

📝 Walkthrough

Walkthrough

Updated documentation for the time_generated parameter in Azure Logs Ingestion: when enabled the timestamp written under time_key is an ISO 8601 string; when disabled the timestamp is a floating-point number of seconds since the Unix epoch.

Changes

Cohort / File(s) Summary
Documentation Update
pipeline/outputs/azure_logs_ingestion.md
Reworded time_generated description to specify timestamp format: ISO 8601 string under time_key when enabled; floating-point seconds-since-epoch when disabled. No behavior or defaults changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 I hopped through docs with nimble paws,
I placed the time in tidy laws,
ISO strings when switches gleam,
Floats return when toggles dream,
A rabbit's patchwork in the docs at ease.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the time_generated parameter description in azure_logs_ingestion documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pipeline/outputs/azure_logs_ingestion.md`:
- Line 35: Update the `time_generated` description to clarify the floating-point
representation: state that when disabled the timestamp is a floating‑point
number representing seconds since the Unix epoch (i.e., Unix time as fractional
seconds), and ensure the wording references `time_key` so it reads: "If
disabled, it is a floating-point number of seconds since the Unix epoch." This
aligns the `time_generated` explanation with other plugin docs (GELF, Plot) and
removes ambiguity about the reference point.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f739d277-ee95-4aa1-a860-810c159ec0b2

📥 Commits

Reviewing files that changed from the base of the PR and between 1481ad4 and 226257d.

📒 Files selected for processing (1)
  • pipeline/outputs/azure_logs_ingestion.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant